Richard,
The project is on life support because of other work I've been doing
on the GWT compiler, but I do intend to revive it soon. I'd be happy
to give committer access, can you send me an example patch with what
you'd like to change for review?
-Ray
On Tue, Mar 16, 2010 at 8:18 PM,
LGTM
On Tue, Mar 16, 2010 at 9:54 PM, rj...@google.com wrote:
Can you look again? I've made a few updates.
http://gwt-code-reviews.appspot.com/224801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This is Avira, isn't it? Ddi you ever hear anything back from them about
this? It seems like it really ought to be fixed on their end, though I
applaud your spelunking for a workaround :)
On Tue, Mar 16, 2010 at 3:08 PM, Matt Mastracci matt...@mastracci.comwrote:
On Mar 16, 12:42 pm, Matt
On Wed, Mar 17, 2010 at 10:48 AM, Joel Webber j...@google.com wrote:
This is Avira, isn't it? Ddi you ever hear anything back from them about
this? It seems like it really ought to be fixed on their end, though I
applaud your spelunking for a workaround :)
Well, they will have to change it
Reviewers: amitmanjhi,
Description:
Introduces expenses scaffolding app, ExpensesScaffold, complete with
event bus and places.
Creates (in bikeshed only, don't panic) new com.google.gwt.app
package, where app framework classes should accumulate. So far that
includes PlaceController et al.
Reviewers: jat,
Description:
Reduce warnings in Eclipse:
o Use ? instead of raw types
o Add some @SuppressWarnings annotations
o Document or remove unused method parameters
Please review this at http://gwt-code-reviews.appspot.com/219803
Affected files:
M
Revision: 7741
Author: rj...@google.com
Date: Wed Mar 17 06:12:58 2010
Log: Update bikeshed/eclipse.README based on feedback from Dan
Review at http://gwt-code-reviews.appspot.com/224801
Review by: r...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7741
Modified:
My previous attempt to submit our code as a false positive disappeared into a
black hole. I did get back a note saying it was acknowledged as a false
positive and our user reports disappeared for a while. Unfortunately, it looks
like they just hacked around the issue - the reports showed up
On Wed, Mar 17, 2010 at 1:22 PM, Matt Mastracci matt...@mastracci.comwrote:
I found a technical support number that I can try calling and seeing if I
can get escalated. If that doesn't work, it might be easier to submit a
minimal, harmless testcase from those keywords as a false positive. :)
Reviewers: scottb, Lex,
Message:
Ready for another look. This patch moves to a more linker-centric
approach.
One note about the change to JUnit.gwt.xml to collapse all properties
(thereby producing one permutation) is that it cuts the time of web-mode
smoke tests by 20-30%.
Description:
This
Additional checkstyle problems (Eclipse output). Please run checkstyle
:)
Description ResourcePathLocationType
forProperties is not
alphabetical. EntityListRequest.java
Bikeshed/src/com/google/gwt/requestfactory/shared line
35 Checkstyle Problem
getDetailsPlaceFor
Awesome test.
Still, what is the use case for globs other than a bare * ?
http://gwt-code-reviews.appspot.com/160801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Mar 17, 2010 at 2:33 PM, sp...@google.com wrote:
Still, what is the use case for globs other than a bare * ?
You mean like:
gecko*
ie*
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Followup question.
- Is Expenses.gwt.xml necessary with the introduction of
ExpensesScaffolding.xml? Can the Expenses.java functionality be moved into
ExpensesScaffolding.java?
On Wed, Mar 17, 2010 at 11:14 AM, amitman...@google.com wrote:
Additional checkstyle problems (Eclipse output).
I found a technical support number that I can try calling and seeing if I can
get escalated. If that doesn't work, it might be easier to submit a minimal,
harmless testcase from those keywords as a false positive. :)
Given their approach, that seems likely to get that exact source added
On Wed, Mar 17, 2010 at 3:10 PM, Matt Mastracci matt...@mastracci.comwrote:
I called their tech support line and left a message to be passed on to
their technical team, but the tech's solution was you'll have to submit
your code again every time it changes. He said he'd pass on the message,
Will do on the checkstyle front.
Yes, we can get rid of the other app. I left it around so that I could
start from a clean slate, and so that I didn't interfere with your work.
Shall I delete it now?
http://gwt-code-reviews.appspot.com/209802
--
On 2010-03-17, at 1:15 PM, John Tamplin wrote:
I called their tech support line and left a message to be passed on to their
technical team, but the tech's solution was you'll have to submit your code
again every time it changes. He said he'd pass on the message, but wouldn't
guarantee that
On Wed, Mar 17, 2010 at 2:48 PM, BobV b...@google.com wrote:
On Wed, Mar 17, 2010 at 2:33 PM, sp...@google.com wrote:
Still, what is the use case for globs other than a bare * ?
You mean like:
gecko*
ie*
Those are trivial already. Is there any new use case enabled by it? -Lex
--
LGTM
http://gwt-code-reviews.appspot.com/225802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Those are trivial already. Is there any new use case enabled by it? -Lex
No, it's just a convenience thing. I'm thinking about localized apps
that would have N-many en_?? kind of locale values.
--
Bob Vawter
Google Web Toolkit Team
--
http://gwt-code-reviews.appspot.com/225802/diff/1/2
File user/super/com/google/gwt/emul/java/util/AbstractHashMap.java
(right):
http://gwt-code-reviews.appspot.com/225802/diff/1/2#newcode279
Line 279: if (hashCode == parseInt(hashCode, 10)) {
How can this make a difference? Even if it is
On Wed, Mar 17, 2010 at 3:52 PM, BobV b...@google.com wrote:
Those are trivial already. Is there any new use case enabled by it?
-Lex
No, it's just a convenience thing. I'm thinking about localized apps
that would have N-many en_?? kind of locale values.
While that may work for some
Hi Ray, its more that I want to apply the critical IE8 patches that
have been there for several months If you were planning on
starting working on it again, then no problem, I'll leave if to you.
On Mar 17, 8:59 pm, Ray Cromwell cromwell...@gmail.com wrote:
Richard,
The project is on life
On 2010/03/17 20:39:47, bowdidge wrote:
It's completely a style thing. Closure Compiler's externs files only
allow
printInt to take two parameters. This code wouldn't be able to
trigger the
incorrect behavior as far as I know.
Ok, LGTM, though perhaps file a bug against Closure Compiler
Revision: 7742
Author: r...@google.com
Date: Wed Mar 17 11:08:23 2010
Log: Checkpoint validation work + some misc stock fixes
http://code.google.com/p/google-web-toolkit/source/detail?r=7742
Added:
/trunk/bikeshed/src/com/google/gwt/bikeshed/sample/validation
Actually, as we just discussed, we probably need both apps. The new one
is what could be reasonably generated by default, while the old one is
more the shape of what you'd build yourself.
http://gwt-code-reviews.appspot.com/209802
--
27 matches
Mail list logo
