Re: [gwt-contrib] Re: CSS Selector Engine

2010-03-29 Thread Manuel Carrasco MoƱino
Hello, I have been using gwtquery for months in many projects where SEO is needed. Is in these kinds of projects with a lot of javascript and SEO, that GWT + gwtquery combination is a fantastic solution (test, reusing, compression, ...). Unfortunately gwtquery has not been updated in a year (I

[gwt-contrib] Re: Comment on UsingOOPHM in google-web-toolkit

2010-03-29 Thread codesite-noreply
Comment by ap.forrest: When we log into our product we launch a new browser window, also we unfortunately use iFrames as a result of legacy code. Both scenarios make it awkward to set the 'gwt.hosted' property on the appropriate URLs. Has anyone else had a similar issue or aware of a

[gwt-contrib] Re: Comment on CodeSplitting in google-web-toolkit

2010-03-29 Thread codesite-noreply
Comment by alyxandorjames: Note to everyone reading this, This guide is somewhat dated. FOR UP TO DATE GUIDELINES, GO TO http://code.google.com/webtoolkit/doc/latest/DevGuideCodeSplitting.html For more information: http://code.google.com/p/google-web-toolkit/wiki/CodeSplitting --

[gwt-contrib] Re: RPC policy files usage?

2010-03-29 Thread Ed
Hi, This issue was driving me nuts.. It costs me so much time to update these policy files (re-deploy/restart server). I even ended up with around 100 policy files whereas I only need about 10 (for different gwt app's against the same backend), but I didn't dare to clean them as I didn't know

[gwt-contrib] [google-web-toolkit] r7804 committed - Eclipse code formatter, do not insert space before array initializer....

2010-03-29 Thread codesite-noreply
Revision: 7804 Author: sco...@google.com Date: Mon Mar 29 04:39:30 2010 Log: Eclipse code formatter, do not insert space before array initializer. This change fixes the conflict with checkstyle when initializing an anootation value with an array.

[gwt-contrib] [google-web-toolkit] r7805 committed - Add a HasKey interface and a maxColumns param for SideBySideTreeView...

2010-03-29 Thread codesite-noreply
Revision: 7805 Author: r...@google.com Date: Mon Mar 29 04:52:13 2010 Log: Add a HasKey interface and a maxColumns param for SideBySideTreeView Note: the location of the getKey() method needs further thought Review at http://gwt-code-reviews.appspot.com/277801 Review by: j...@google.com

[gwt-contrib] [google-web-toolkit] r7808 committed - Edited wiki page through web user interface.

2010-03-29 Thread codesite-noreply
Revision: 7808 Author: sp...@google.com Date: Mon Mar 29 08:30:22 2010 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7808 Modified: /wiki/CodeSplitting.wiki === --- /wiki/CodeSplitting.wiki

[gwt-contrib] [google-web-toolkit] r7807 committed - Checkstyle fixes

2010-03-29 Thread codesite-noreply
Revision: 7807 Author: r...@google.com Date: Mon Mar 29 05:18:51 2010 Log: Checkstyle fixes http://code.google.com/p/google-web-toolkit/source/detail?r=7807 Modified: /trunk/bikeshed/src/com/google/gwt/sample/bikeshed/stocks/client/StocksDesktop.java

[gwt-contrib] [google-web-toolkit] r7809 committed - Mail sample app to work on selection concepts

2010-03-29 Thread codesite-noreply
Revision: 7809 Author: r...@google.com Date: Mon Mar 29 05:42:31 2010 Log: Mail sample app to work on selection concepts http://code.google.com/p/google-web-toolkit/source/detail?r=7809 Added: /trunk/bikeshed/src/com/google/gwt/bikeshed/list/shared/SelectionModel.java

[gwt-contrib] Remove JDK 1.6-isms; fix a checkstyle warning (issue281801)

2010-03-29 Thread rice
Reviewers: Lex, Description: Remove JDK 1.6-isms; fix a checkstyle warning Please review this at http://gwt-code-reviews.appspot.com/281801/show Affected files: M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M

[gwt-contrib] [google-web-toolkit] r7810 committed - Making a snapshot branch as a direct copy from trunk at r7809.

2010-03-29 Thread codesite-noreply
Revision: 7810 Author: sp...@google.com Date: Mon Mar 29 09:55:42 2010 Log: Making a snapshot branch as a direct copy from trunk at r7809. http://code.google.com/p/google-web-toolkit/source/detail?r=7810 Added: /branches/snapshot-2010.03.26 --

Re: [gwt-contrib] Remove JDK 1.6-isms; fix a checkstyle warning (issue281801)

2010-03-29 Thread Scott Blum
Dan, I actually just submitted without review the @Overrides removals. On Mon, Mar 29, 2010 at 12:29 PM, r...@google.com wrote: Reviewers: Lex, Description: Remove JDK 1.6-isms; fix a checkstyle warning Please review this at http://gwt-code-reviews.appspot.com/281801/show Affected

Re: [gwt-contrib] Remove JDK 1.6-isms; fix a checkstyle warning (issue281801)

2010-03-29 Thread Scott Blum
On Mon, Mar 29, 2010 at 1:05 PM, Scott Blum sco...@google.com wrote: Dan, I actually just submitted without review the @Overrides removals. Well, not the one in CrossSiteLoadingStrategy, my patch was older. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe

[gwt-contrib] [google-web-toolkit] r7811 committed - Removing interface @Overrides for Java 1.5 compatibility....

2010-03-29 Thread codesite-noreply
Revision: 7811 Author: sco...@google.com Date: Mon Mar 29 07:02:30 2010 Log: Removing interface @Overrides for Java 1.5 compatibility. Review by: sp...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=7811 Modified:

[gwt-contrib] [google-web-toolkit] r7812 committed - Deleting this manually created snapshot branch. There's a new script ...

2010-03-29 Thread codesite-noreply
Revision: 7812 Author: sp...@google.com Date: Mon Mar 29 10:28:53 2010 Log: Deleting this manually created snapshot branch. There's a new script in town. http://code.google.com/p/google-web-toolkit/source/detail?r=7812 Deleted: /branches/snapshot-2010.03.26 --

[gwt-contrib] [google-web-toolkit] r7813 committed - Created new snapshot branch via:...

2010-03-29 Thread codesite-noreply
Revision: 7813 Author: sp...@google.com Date: Mon Mar 29 10:31:06 2010 Log: Created new snapshot branch via: svn cp -r7809 https://google-web-toolkit.googlecode.com/svn/trunk \ https://google-web-toolkit.googlecode.com/svn/branches/snapshot-2010.03.29-r7809

[gwt-contrib] Skeletal support for tracking generator dependencies and skipping (issue283801)

2010-03-29 Thread spoon
Reviewers: Lex, Description: Skeletal support for tracking generator dependencies and skipping reruns of generators. Please review this at http://gwt-code-reviews.appspot.com/283801/show Affected files: M dev/core/src/com/google/gwt/dev/DevModeBase.java M

[gwt-contrib] Re: Skeletal support for tracking generator dependencies and skipping (issue283801)

2010-03-29 Thread spoon
There are three main parts to focus on: 1. The interface RuleRealizeCache is what must be implemented to track dependencies and decide when a previous result can be reused. Please see the comments in that file for how the API works. 2. ResourceOracle can have a dependency tracker plugged into

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

2010-03-29 Thread rjrjr
Thanks for your patience, Marko, and sorry to be so inconsiderate of your time. http://gwt-code-reviews.appspot.com/154810/diff/1001/1002 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right): http://gwt-code-reviews.appspot.com/154810/diff/1001/1002#newcode37

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

2010-03-29 Thread rjrjr
One other note: your patch is very likely to land after http://gwt-code-reviews.appspot.com/241801, and may need to be tweaked. Take a look at the element parser changes there to get a feel for it. http://gwt-code-reviews.appspot.com/154810/show --

[gwt-contrib] Make ServletValidator not use Jetty (issue284801)

2010-03-29 Thread scottb
Reviewers: bobv, Message: Please review. Description: See http://code.google.com/p/google-web-toolkit/issues/detail?id=4760 Please review this at http://gwt-code-reviews.appspot.com/284801/show Affected files: M dev/core/src/com/google/gwt/dev/ServletValidator.java M

[gwt-contrib] SelectionScriptLinker was setting the wrong timestamp on (issue287801)

2010-03-29 Thread spoon
Reviewers: scottb, Description: SelectionScriptLinker was setting the wrong timestamp on the generated selection script when used in production mode. It mistakenly thought it was in dev mode. Review by: sco...@google.com Please review this at http://gwt-code-reviews.appspot.com/287801/show

[gwt-contrib] Re: SelectionScriptLinker was setting the wrong timestamp on (issue287801)

2010-03-29 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/287801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.

[gwt-contrib] The servlet now reads the enum name from a properties file. Thus, the servlet (issue286802)

2010-03-29 Thread amitmanjhi
Reviewers: Ray Ryan, Description: The servlet now reads the enum name from a properties file. Thus, the servlet portion responsible for all READ operations is a stock servlet. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at

[gwt-contrib] Re: The servlet now reads the enum name from a properties file. Thus, the servlet (issue286802)

2010-03-29 Thread rjrjr
LGTM, with one comment nit below. http://gwt-code-reviews.appspot.com/286802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words

[gwt-contrib] BinaryEmittedArtifact now forces subclasses to implement getLastModified. (issue288801)

2010-03-29 Thread scottb
Reviewers: Lex, Message: Please review. Description: Also: - Link.legacyLink once again deletes the module output directory, fixing r6497. - Intermediate linking individual permutations into a jar now preserves the timestamp. Please review this at

[gwt-contrib] Removes the completely spurious generatedResource directory. (issue289801)

2010-03-29 Thread scottb
Reviewers: jat, bobv, Description: The generatedResource directory was an artifact of earlier times. We were literally writing generated resources out to temporary files, just so we could immediately read them back in. This should speed up generators by avoiding most disk I/O. Please review

[gwt-contrib] Implements a reduced scope ValueStore. It's responsible for posting change events (issue290801)

2010-03-29 Thread rjrjr
Reviewers: amitmanjhi, Description: Implements a reduced scope ValueStore. It's responsible for posting change events to the event bus, and for collecting changes to domain objects. You can tell it's working because the editing feature of the Expense app now actually refreshes its table. Review