Can you make sure that contrib is cc'd in the issue settings?
http://gwt-code-reviews.appspot.com/612802/diff/1/2
File user/src/com/google/gwt/user/client/ui/Panel.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/2#newcode231
http://gwt-code-reviews.appspot.com/612802/diff/1/2
File user/src/com/google/gwt/user/client/ui/Panel.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/2#newcode231
user/src/com/google/gwt/user/client/ui/Panel.java:231: private static
native void eraseDom(Element element) /*-{
I
http://gwt-code-reviews.appspot.com/612802/diff/1/3
File user/test/com/google/gwt/user/client/ui/RootPanelTest.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode51
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:51: public
void testClearWithDomErasure() {
I
Reviewers: Ray Ryan,
Description:
Added a warning to the javadoc of each src file and to package.html in
the app, requestfactory, and valuestore modules.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/625801/show
Affected files:
M
LGTM
On Wed, Jun 16, 2010 at 10:57 AM, amitman...@google.com wrote:
Reviewers: Ray Ryan,
Description:
Added a warning to the javadoc of each src file and to package.html in
the app, requestfactory, and valuestore modules.
Review by: rj...@google.com
Please review this at
Revision: 8263
Author: amitman...@google.com
Date: Wed Jun 16 08:14:54 2010
Log: Added a warning to the javadoc of each src file and to package.html in
the app, requestfactory, and valuestore modules.
Review at http://gwt-code-reviews.appspot.com/625801
Review by: rj...@google.com
Reviewers: Ray Ryan,
Description:
Deleted HasPages, HasValueMap, and ValueListBox since they are not being
used.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/619802/show
Affected files:
D bikeshed/src/com/google/gwt/user/client/ui/HasPages.java
D
LGTM
http://gwt-code-reviews.appspot.com/619802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8264
Author: amitman...@google.com
Date: Wed Jun 16 08:40:15 2010
Log: Deleted HasPages, HasValueMap, and ValueListBox since they are not
being used.
Review at http://gwt-code-reviews.appspot.com/619802
Review by: rj...@google.com
Reviewers: jat,
Description:
Improve wire format for primitive long values. Keep support for the
previous format in server-side code.
Please review this at http://gwt-code-reviews.appspot.com/626801/show
Affected files:
M dev/core/super/com/google/gwt/lang/LongLib.java
M
I have moved the test to PanelTestBase class. I have also tried to
subclass the RootPanelTest from the PanelTestClass but got the following
error
estcase: testAttachDetachOrder took 301.037 sec
Caused an ERROR
The browser did not complete the test method
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
Thanks
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
right
LGTM with nits.
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
Why do we need quotes?
Revision: 8265
Author: unn...@google.com
Date: Wed Jun 16 09:32:10 2010
Log: Moving this chang over from the IO branch (the other logging change
had to be moved first)
A clean move.
Review by: sp...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8265
Added:
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
Should
I'm willing to live with that risk. It's already kind of crazily
belts-and-suspenders to have all the redundant invocations of
PanelTestBase via subclass. It would make more sense to just test Panel
directly, and rely on subclasses that override the bits it tests to
provide their own tests for
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
Fields in the RPC stream are JS literals that get
Revision: 8266
Author: amitman...@google.com
Date: Wed Jun 16 10:08:50 2010
Log: Removed PrintWriterManager from bikeshed and inlined its use in
bikeshed.
Review at http://gwt-code-reviews.appspot.com/627801
Review by: rj...@google.com
http://gwt-code-reviews.appspot.com/626801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
On 2010/06/16 20:13:28, Dan Rice wrote:
Revision: 8267
Author: gwt.mirror...@gmail.com
Date: Wed Jun 16 13:56:33 2010
Log: earlier mirror fix only got the additive changes; here are the
subtractives.
http://code.google.com/p/google-web-toolkit/source/detail?r=8267
Deleted:
Hopefully there will be no problems with this last patch. :)
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Description:
Add useful hooks into GWT to allow other tools to parse and analyze Java
code.
Please review this at http://gwt-code-reviews.appspot.com/631801/show
Affected files:
M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
M
Reviewers: scottb, jat, Lex,
Description:
Increase logging in JUnitShell and HtmlUnit to provide more diagnostic
information during test failures.
Please review this at http://gwt-code-reviews.appspot.com/632802/show
Affected files:
M dev/core/src/com/google/gwt/dev/DevMode.java
M
Can you give details about what exactly you want to accomplish?
http://gwt-code-reviews.appspot.com/632802/diff/1/2
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/632802/diff/1/2#newcode428
dev/core/src/com/google/gwt/dev/DevMode.java:428:
Revision: 8269
Author: r...@google.com
Date: Wed Jun 16 15:55:40 2010
Log: Improve wire format for primitive long values. Keep support for the
previous format in server-side code.
Review at http://gwt-code-reviews.appspot.com/626801
Review by: j...@google.com
Revision: 8270
Author: amitman...@google.com
Date: Wed Jun 16 16:16:10 2010
Log: Removed the appengine tools-api.jar, no longer needed with appEngine
1.3.4
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8270
Deleted:
While you're in here, any chance you could do something more sane to
JUnitHostImpl's failure mode when it can't deserialize an exception
(this happens 100% of the time when testing with no metadata).
http://gwt-code-reviews.appspot.com/632802/diff/1/2
File
Another iteration of the patch that simplifies the cross-casting of JSO
subtype arrays by upcasting all JSO subtype arrays to
JavaScriptObject[]. This ensures that array object identity will be
preserved, even after an illegal cast between incompatible array
types.
Changes to look at:
- Added
31 matches
Mail list logo
