[gwt-contrib] Re: Maven dependencies for gwt-dev

2010-06-21 Thread Ben Harris
I've made a set of poms for gwt-dev, gwt-user, gwt-servlet, gwt-soyc- vis and gwt-bikeshed that builds from the current 2.1-SNAPSHOT (Except building bikeshed was broken with the changes made over the weekend). They all work with gwt-maven-plugin (only gwt-dev needs the dependencies to be bundled

[gwt-contrib] Re: A sample for logging (issue641801)

2010-06-21 Thread markovuksanovic
I think that .project, .classpath and .checkstyle files should be included. All the other samples have those files imported. It is possible to create the eclipse project from sources but I think it would be much more convenient if the project was already created for the user. I also think that

[gwt-contrib] Can linkers access source files?

2010-06-21 Thread Marko Vuksanovic
Is it possible to use a linker to scan the source files which were compiled? I would think that linker has access only to files that are actually output of the compilePerms (and possible PreCompile), but I may very well be wrong If I cannot use linker to analyze java code, is there a hook

Re: [gwt-contrib] Can linkers access source files?

2010-06-21 Thread John Tamplin
On Mon, Jun 21, 2010 at 9:06 AM, Marko Vuksanovic markovuksano...@gmail.com wrote: Is it possible to use a linker to scan the source files which were compiled? I would think that linker has access only to files that are actually output of the compilePerms (and possible PreCompile), but I may

[gwt-contrib] Re: Can linkers access source files?

2010-06-21 Thread Marko Vuksanovic
Thanks for the response, John. Are there any plans to implement something like this? On Jun 21, 3:16 pm, John Tamplin j...@google.com wrote: On Mon, Jun 21, 2010 at 9:06 AM, Marko Vuksanovic markovuksano...@gmail.com wrote: Is it possible to use a linker to scan the source files which were

[gwt-contrib] Re: UiBinder. Add tests for horizontal/vertical alignment parsers. (issue633801)

2010-06-21 Thread jgw
On 2010/06/17 08:52:37, Konstantin.Scheglov wrote: Thanks, LGTM. Submitted at r8281. http://gwt-code-reviews.appspot.com/633801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Can linkers access source files?

2010-06-21 Thread John Tamplin
On Mon, Jun 21, 2010 at 9:23 AM, Marko Vuksanovic markovuksano...@gmail.com wrote: Thanks for the response, John. Are there any plans to implement something like this? Not that I know of. Linkers may run on a machine separate from where the source is, so allowing them access to the source

[gwt-contrib] Re: Fix issue 150: regression re. keyCode/charCode (issue643801)

2010-06-21 Thread jlabanca
LGTM With the note that it might make sense to just pull some of the deprecated code than try to fix it. http://gwt-code-reviews.appspot.com/643801/diff/1/5 File user/src/com/google/gwt/user/client/ui/PopupPanel.java (right): http://gwt-code-reviews.appspot.com/643801/diff/1/5#newcode1362

[gwt-contrib] Re: Can linkers access source files?

2010-06-21 Thread Marko Vuksanovic
Well, the idea is to be able to somehow analyze the input and see how it is related to some output. I know that it is possible to achieve this without messing gwt compiler itself (just run some code before the compiler starts its job). Its just that it would be a nice feature to be able to take

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

2010-06-21 Thread markovuksanovic
@jat, Any news about this? http://gwt-code-reviews.appspot.com/620802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-21 Thread rchandia
http://gwt-code-reviews.appspot.com/636801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: A sample for logging (issue641801)

2010-06-21 Thread Unnur Gretarsdottir
Sure - that sounds reasonable - I'll add those today. On Mon, Jun 21, 2010 at 2:49 AM, markovuksano...@gmail.com wrote: I think that .project, .classpath and .checkstyle files should be included. All the other samples have those files imported. It is possible to create the eclipse project

[gwt-contrib] Any ETA for 2.1?

2010-06-21 Thread Thomas Broyer
Hi Googlers^H^H G-men! Do you have any ETA for 2.1 M2 (or RC1?), and/or 2.1 GA? We're looking at RequestFactory, ActivityManager and data presentation widgets for a new project, but they're far from complete now (particularly RequestFactory, and ActivityManager isn't plugged with the History).

[gwt-contrib] Re: Adds a simple JJS test to ensure enums work (issue640803)

2010-06-21 Thread spoon
LGTM http://gwt-code-reviews.appspot.com/640803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8289 committed - Removes redundant width/height parsing in DockLayoutPanel....

2010-06-21 Thread codesite-noreply
Revision: 8289 Author: j...@google.com Date: Mon Jun 21 06:45:34 2010 Log: Removes redundant width/height parsing in DockLayoutPanel. Review at http://gwt-code-reviews.appspot.com/633802 http://code.google.com/p/google-web-toolkit/source/detail?r=8289 Modified:

[gwt-contrib] [google-web-toolkit] r8290 committed - Adds a simple JJS test to verify that enums compile....

2010-06-21 Thread codesite-noreply
Revision: 8290 Author: sco...@google.com Date: Mon Jun 21 08:04:24 2010 Log: Adds a simple JJS test to verify that enums compile. TODO: improve this test. http://gwt-code-reviews.appspot.com/640803/show Review by: spoon http://code.google.com/p/google-web-toolkit/source/detail?r=8290 Added:

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-21 Thread rice
LGTM with comments http://gwt-code-reviews.appspot.com/636801/diff/6001/7003 File /bikeshed/src/com/google/gwt/collections/MutableSet.java (right): http://gwt-code-reviews.appspot.com/636801/diff/6001/7003#newcode23 /bikeshed/src/com/google/gwt/collections/MutableSet.java:23: * creating the

[gwt-contrib] Re: Add Firefox 3.7alpha support (issue638801)

2010-06-21 Thread conroy
http://gwt-code-reviews.appspot.com/638801/diff/1/3 File plugins/xpcom/Makefile (right): http://gwt-code-reviews.appspot.com/638801/diff/1/3#newcode130 plugins/xpcom/Makefile:130: -lxpcomglue_s -lxpcom -lnspr4 -lmozjs for 3.7 we also need to link against mozalloc ifeq ($BROWSER,ff40) DLLFLAGS

[gwt-contrib] Re: Introduces com.google.gwt.text from bikeshed, along with changes in (issue649801)

2010-06-21 Thread johan . rydberg
http://gwt-code-reviews.appspot.com/649801/diff/1/88 File user/src/com/google/gwt/user/client/ui/ValueBoxBase.java (right): http://gwt-code-reviews.appspot.com/649801/diff/1/88#newcode46 user/src/com/google/gwt/user/client/ui/ValueBoxBase.java:46: SourcesChangeEvents, HasChangeHandlers,

Re: [gwt-contrib] Any ETA for 2.1?

2010-06-21 Thread Chris Ramsdale
While this shouldn't be taken as a binding set of dates, we are looking to wrap up a 2.1 RC in late Q3, with GA release in early Q4. On Mon, Jun 21, 2010 at 12:30 PM, Thomas Broyer t.bro...@gmail.com wrote: Hi Googlers^H^H G-men! Do you have any ETA for 2.1 M2 (or RC1?), and/or 2.1 GA?

Re: [gwt-contrib] Any ETA for 2.1?

2010-06-21 Thread Joel Webber
We're also working to get the new widgets libraries stabilized well before that, though we don't have hard dates. One thing to look for would be the removal of the Note: This class is new and its interface subject to change. warnings in the javadoc. Or just ask here :) Le 21 juin 2010 14:29,

[gwt-contrib] Re: DockPanelParser and width/height attributes (issue633802)

2010-06-21 Thread jgw
On 2010/06/18 15:02:50, Konstantin.Scheglov wrote: Thanks, LGTM. Committed at r8289. http://gwt-code-reviews.appspot.com/633802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] mail patch

2010-06-21 Thread Joel Webber
Thanks, Stephen. @Dan: Is this still applicable, or has it been fixed already? Le 9 juin 2010 13:21, Stephen Haberman step...@exigencecorp.com a écrit : Hi, I was playing with the Mail example this morning and saw a stack trace casting the Message class to Comparable for the TreeMap inside

[gwt-contrib] Adds integral BiDi support to Label.java and its descendants. Introduces a new interface, HasAut... (issue642803)

2010-06-21 Thread tomerigo
Reviewers: jat, jlabanca, Description: Adds integral BiDi support to Label.java and its descendants. Introduces a new interface, HasAutoHorizontalAlignment. Please review this at http://gwt-code-reviews.appspot.com/642803/show Affected files: M

Re: [gwt-contrib] UiBinder. Code style for constant parsers.

2010-06-21 Thread Joel Webber
Le 19 juin 2010 10:34, Konstantin.Scheglov konstantin.scheg...@gmail.com a écrit : Why existing horizontal/vertical alignment parsers use so unfriendly names for alignments? ALIGN_RIGHT looks not very good in XML. Why not just right? This would be more natural for people with HTML

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-21 Thread rice
FYI - let's do one more round http://gwt-code-reviews.appspot.com/636801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Set and MutableSet. Bytecode implementation. (issue636801)

2010-06-21 Thread rchandia
On 2010/06/21 20:22:27, Dan Rice wrote: FYI - let's do one more round Sure http://gwt-code-reviews.appspot.com/636801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

2010-06-21 Thread rice
FYI http://gwt-code-reviews.appspot.com/620802/diff/8001/9001 File user/super/com/google/gwt/emul/java/util/AbstractList.java (right): http://gwt-code-reviews.appspot.com/620802/diff/8001/9001#newcode144 user/super/com/google/gwt/emul/java/util/AbstractList.java:144: } I think you also need to

Re: [gwt-contrib] mail patch

2010-06-21 Thread דניאל רייס
Looks like the code is still the same as what he is seeing -- I haven't seen the stack trace and don't know how to repo it but the fix seems reasonable. Dan On Mon, Jun 21, 2010 at 3:22 PM, Joel Webber j...@google.com wrote: Thanks, Stephen. @Dan: Is this still applicable, or has it been

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

2010-06-21 Thread markovuksanovic
I have one question... in javadoc is says The semantics of the list returned by this method become undefined if the backing list (i.e., this list) is structurally modified in any way other than via the returned list. (Structural modifications are those that change the size of this list, or

[gwt-contrib] Better implementation for getHandlers (the old one threw an exception in Web mode) (issue651801)

2010-06-21 Thread unnurg
Reviewers: fredsa, Description: Better implementation for getHandlers (the old one threw an exception in Web mode) Please review this at http://gwt-code-reviews.appspot.com/651801/show Affected files: M user/src/com/google/gwt/logging/impl/LoggerImplRegular.java Index:

[gwt-contrib] Re: Better implementation for getHandlers (the old one threw an exception in Web mode) (issue651801)

2010-06-21 Thread jat
LGTM http://gwt-code-reviews.appspot.com/651801/diff/1/2 File user/src/com/google/gwt/logging/impl/LoggerImplRegular.java (right): http://gwt-code-reviews.appspot.com/651801/diff/1/2#newcode64 user/src/com/google/gwt/logging/impl/LoggerImplRegular.java:64: return handlers.toArray(new

[gwt-contrib] Re: Better implementation for getHandlers (the old one threw an exception in Web mode) (issue651801)

2010-06-21 Thread Unnur Gretarsdottir
sweet - thanks for the quick review! On Mon, Jun 21, 2010 at 3:41 PM, j...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/651801/diff/1/2 File user/src/com/google/gwt/logging/impl/LoggerImplRegular.java (right): http://gwt-code-reviews.appspot.com/651801/diff/1/2#newcode64

[gwt-contrib] Remove the Remote Logger checkbox (forgotten when I removed the code to handle this box) (issue618802)

2010-06-21 Thread unnurg
Reviewers: fredsa, Description: Remove the Remote Logger checkbox (forgotten when I removed the code to handle this box) Please review this at http://gwt-code-reviews.appspot.com/618802/show Affected files: M

[gwt-contrib] Re: Remove the Remote Logger checkbox (forgotten when I removed the code to handle this box) (issue618802)

2010-06-21 Thread fredsa
LGTM http://gwt-code-reviews.appspot.com/618802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8291 committed - Remove the Remote Logger checkbox (forgotten when I removed the code t...

2010-06-21 Thread codesite-noreply
Revision: 8291 Author: unn...@google.com Date: Mon Jun 21 15:04:17 2010 Log: Remove the Remote Logger checkbox (forgotten when I removed the code to handle this box) Review at http://gwt-code-reviews.appspot.com/618802 Review by: fre...@google.com