[gwt-contrib] [google-web-toolkit] r8310 committed - Added the api warning for newly added classes....

2010-06-23 Thread codesite-noreply
Revision: 8310 Author: amitman...@google.com Date: Wed Jun 23 15:29:19 2010 Log: Added the api warning for newly added classes. Patch by: amitmanjhi Review by: rjrjr (tbr) Review at http://gwt-code-reviews.appspot.com/619804 http://code.google.com/p/google-web-toolkit/source/detail?r=8310 Modi

[gwt-contrib] Added the api warning for newly added classes. (issue619804)

2010-06-23 Thread amitmanjhi
Reviewers: Ray Ryan, Description: Added the api warning for newly added classes. Patch by: amitmanjhi Review by: rjrjr (tbr) Please review this at http://gwt-code-reviews.appspot.com/619804/show Affected files: M bikeshed/src/com/google/gwt/requestfactory/server/DefaultSecurityProvider.ja

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

2010-06-23 Thread jat
Slightly different fix committed to trunk at r8308. http://gwt-code-reviews.appspot.com/620802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Bye Bye Boilerplate patch. No static configuration required for servlet (issue661801)

2010-06-23 Thread amitmanjhi
This time with the correct URL http://gwt-code-reviews.appspot.com/648802/show On 2010/06/23 23:13:19, amitmanjhi wrote: On 2010/06/23 23:07:45, amitmanjhi wrote: > Patch is updated version of Ray Cromwell's original patch: http://gwt-code-reviews.appspot.com/661801 http://gwt-code-review

[gwt-contrib] Re: Bye Bye Boilerplate patch. No static configuration required for servlet (issue661801)

2010-06-23 Thread amitmanjhi
On 2010/06/23 23:07:45, amitmanjhi wrote: Patch is updated version of Ray Cromwell's original patch: http://gwt-code-reviews.appspot.com/661801 http://gwt-code-reviews.appspot.com/661801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Bye Bye Boilerplate patch. No static configuration required for servlet (issue661801)

2010-06-23 Thread amitmanjhi
Reviewers: cromwellian, Description: Bye Bye Boilerplate patch. No static configuration required for servlet beyond @Service annotations on request interfaces and @DataTransferObject annotations on Record types. TOKEN no longer required on Record types, as the class itself is used as a token. I

[gwt-contrib] [google-web-toolkit] r8308 committed - Fixes List.subList problems....

2010-06-23 Thread codesite-noreply
Revision: 8308 Author: j...@google.com Date: Wed Jun 23 11:50:26 2010 Log: Fixes List.subList problems. Public review at: http://gwt-code-reviews.appspot.com/620802/show Issue: 4993 Patch by: markovuksano...@gmail.com Review by: jat, rice http://code.google.com/p/google-web-toolkit/source/detai

[gwt-contrib] [google-web-toolkit] r8307 committed - Merged trunk r8293 into this branch...

2010-06-23 Thread codesite-noreply
Revision: 8307 Author: j...@google.com Date: Wed Jun 23 14:48:11 2010 Log: Merged trunk r8293 into this branch Escaping HTML strings from the client as a good practice to avoid XSS vulnerabilities in apps the build off of the default app. svn merge -c8293 --ignore-ancestry https://google-we

[gwt-contrib] [google-web-toolkit] r8306 committed - Merge trunk r8300 into this branch...

2010-06-23 Thread codesite-noreply
Revision: 8306 Author: j...@google.com Date: Wed Jun 23 14:35:13 2010 Log: Merge trunk r8300 into this branch Adds a workaround for a Safari 5 bug regarding right-shift operators. svn merge -c8300 --ignore-ancestry https://google-web-toolkit.googlecode.com/svn/trunk http://code.google.com/p

[gwt-contrib] Re: Finishing implementation of ListViewAdapter. An extensive test class will be submitted in a lat... (issue636802)

2010-06-23 Thread jlabanca
committed as r8305 http://gwt-code-reviews.appspot.com/636802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8305 committed - Finishing implementation of ListViewAdapter. An extensive test class ...

2010-06-23 Thread codesite-noreply
Revision: 8305 Author: gwt.mirror...@gmail.com Date: Wed Jun 23 13:30:51 2010 Log: Finishing implementation of ListViewAdapter. An extensive test class will be submitted in a later change because the rest relies on API changes that haven't been submitted yet. Review at http://gwt-code-revie

[gwt-contrib] Re: DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jgw
On 2010/06/23 19:08:30, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/658801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jlabanca
http://gwt-code-reviews.appspot.com/658801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jlabanca
http://gwt-code-reviews.appspot.com/658801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix external issue 5052 - JSONParser.parse exceptions with some unicode characters (issue659801)

2010-06-23 Thread jat
http://gwt-code-reviews.appspot.com/659801/diff/1/2 File user/src/com/google/gwt/json/client/JSONParser.java (right): http://gwt-code-reviews.appspot.com/659801/diff/1/2#newcode55 user/src/com/google/gwt/json/client/JSONParser.java:55: jsonString = jsonString.replace("\u2029", "\\u2029"); On 201

[gwt-contrib] Re: Fix external issue 5052 - JSONParser.parse exceptions with some unicode characters (issue659801)

2010-06-23 Thread rice
http://gwt-code-reviews.appspot.com/659801/diff/1/2 File user/src/com/google/gwt/json/client/JSONParser.java (right): http://gwt-code-reviews.appspot.com/659801/diff/1/2#newcode55 user/src/com/google/gwt/json/client/JSONParser.java:55: jsonString = jsonString.replace("\u2029", "\\u2029"); No, I'

[gwt-contrib] Re: Fix external issue 5052 - JSONParser.parse exceptions with some unicode characters (issue659801)

2010-06-23 Thread jat
http://gwt-code-reviews.appspot.com/659801/diff/1/2 File user/src/com/google/gwt/json/client/JSONParser.java (right): http://gwt-code-reviews.appspot.com/659801/diff/1/2#newcode55 user/src/com/google/gwt/json/client/JSONParser.java:55: jsonString = jsonString.replace("\u2029", "\\u2029"); Are yo

[gwt-contrib] Re: DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jgw
On 2010/06/23 18:28:32, jlabanca wrote: Is there a test suite to which tese should be added? http://gwt-code-reviews.appspot.com/658801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Finishing implementation of ListViewAdapter. An extensive test class will be submitted in a lat... (issue636802)

2010-06-23 Thread jgw
On 2010/06/23 18:29:32, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/636802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Setting the default selection model in DefaultNodeInfo to null. Having a selection model per nod... (issue657801)

2010-06-23 Thread rice
LGTM http://gwt-code-reviews.appspot.com/657801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix external issue 5052 - JSONParser.parse exceptions with some unicode characters (issue659801)

2010-06-23 Thread rice
Reviewers: jat, Description: Fix external issue 5052 - JSONParser.parse exceptions with some unicode characters Please review this at http://gwt-code-reviews.appspot.com/659801/show Affected files: M user/src/com/google/gwt/json/client/JSONParser.java M user/test/com/google/gwt/json/client

[gwt-contrib] Finishing implementation of ListViewAdapter. An extensive test class will be submitted in a lat... (issue636802)

2010-06-23 Thread jlabanca
Reviewers: jgw, Description: Finishing implementation of ListViewAdapter. An extensive test class will be submitted in a later change because the rest relies on API changes that haven't been submitted yet. Please review this at http://gwt-code-reviews.appspot.com/636802/show Affected files:

[gwt-contrib] DefaultSelectionModel#setSelected currently adds an exception even if the default selection stat... (issue658801)

2010-06-23 Thread jlabanca
Reviewers: jgw, Description: DefaultSelectionModel#setSelected currently adds an exception even if the default selection state equals the specified state. Also adds test cases for all selection models. Please review this at http://gwt-code-reviews.appspot.com/658801/show Affected files: M us

[gwt-contrib] Column should not use a singleton FieldUpdater because the Cell may hang on to the FieldUpdater.... (issue620803)

2010-06-23 Thread jlabanca
Reviewers: Dan Rice, Description: Column should not use a singleton FieldUpdater because the Cell may hang on to the FieldUpdater. We now create a new instance each time. Please review this at http://gwt-code-reviews.appspot.com/620803/show Affected files: M user/src/com/google/gwt/user/cell

[gwt-contrib] Setting the default selection model in DefaultNodeInfo to null. Having a selection model per nod... (issue657801)

2010-06-23 Thread jlabanca
Reviewers: Dan Rice, Description: Setting the default selection model in DefaultNodeInfo to null. Having a selection model per node is almost always incorrect. Users should supply a single Selectionmodel for the entire tree in most cases. Please review this at http://gwt-code-reviews.appspot.co

[gwt-contrib] Re: Adding a null check to ShowcaseGenerator so that we don't try to write to a public resource that... (issue646802)

2010-06-23 Thread jlabanca
committed as r8304 http://gwt-code-reviews.appspot.com/646802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: List.subList not fully compatibile with java.util.List interface. (issue620802)

2010-06-23 Thread markovuksanovic
http://gwt-code-reviews.appspot.com/620802/diff/4002/19001 File user/super/com/google/gwt/emul/java/util/AbstractList.java (right): http://gwt-code-reviews.appspot.com/620802/diff/4002/19001#newcode166 user/super/com/google/gwt/emul/java/util/AbstractList.java:166: @rice I have overridden this m

[gwt-contrib] [google-web-toolkit] r8304 committed - Adding a null check to ShowcaseGenerator so that we don't try to write...

2010-06-23 Thread codesite-noreply
Revision: 8304 Author: gwt.mirror...@gmail.com Date: Wed Jun 23 08:52:39 2010 Log: Adding a null check to ShowcaseGenerator so that we don't try to write to a public resource that has already been created. This fixes a bug when multiple examples reference the same raw source files. Review a

Re: [gwt-contrib] Re: UiBinder. Code style for constant parsers.

2010-06-23 Thread Konstantin Scheglov
On Wed, Jun 23, 2010 at 5:49 PM, Joel Webber wrote: > Le 22 juin 2010 07:03, Konstantin.Scheglov a > écrit : > > >> > Pretty much everything we've done so far has been limited to >> automatically >> > exposing the Java-level APIs in all their ugliness. The h/v alignment >> values >> > are implem

Re: [gwt-contrib] Re: UiBinder. Code style for constant parsers.

2010-06-23 Thread Joel Webber
Le 22 juin 2010 07:03, Konstantin.Scheglov a écrit : > > > Pretty much everything we've done so far has been limited to > automatically > > exposing the Java-level APIs in all their ugliness. The h/v alignment > values > > are implemented somewhat manually, but for things like enums I really > li

[gwt-contrib] Re: UiBinder. Parser for TextAlignConstant (issue612803)

2010-06-23 Thread Joel Webber
@rjrjr: What say ye? Have you considered doing something like this before, and perhaps found a way to generalize it such that we don't have to create a separate attribute parser for every enum? Le 22 juin 2010 07:14, a écrit : > Reviewers: jgw, > > Description: > It uses "friendly" names. > > I

Re: [gwt-contrib] UiBinder tweaks for GWT Designer

2010-06-23 Thread Joel Webber
Konstantin, I've not gone over these proposals in great detail, but it does seem like a reasonable idea to build "design time" hooks into UiBinder-generated code. One very important caveat would be that it must be possible for the compiler to strip them out completely in production mode (this seem

[gwt-contrib] [google-web-toolkit] r8303 committed - Added Hilbrand Bouwkamp for gwt-google-apis contribution

2010-06-23 Thread codesite-noreply
Revision: 8303 Author: zun...@google.com Date: Wed Jun 23 05:53:44 2010 Log: Added Hilbrand Bouwkamp for gwt-google-apis contribution http://code.google.com/p/google-web-toolkit/source/detail?r=8303 Modified: /CLA-SIGNERS === --- /CLA-SIGNERSFri Apr

[gwt-contrib] UiBinder tweaks for GWT Designer

2010-06-23 Thread Konstantin.Scheglov
To support UiBinder in GWT Designer we need to have several changes in UiBinder generators, writer and parsers. I will describe below these changes as they are done now. In real patch I will group as much implementation details as possible into single class like DesignTimeUtils or GWTDesigne