Reviewers: jgw,
Description:
Modifies the cross-site linker to put its code in an iframe
rather than a wrapper function.
Review by: j...@google.com
Please review this at http://gwt-code-reviews.appspot.com/674802/show
Affected files:
M dev/core/src/com/google/gwt/core/linker/XSLinker.java
Hello,
Currently the template javascript files IFrameTemplate.js,
SingleScriptTemplate.js, and XSTemplate.js in com/google/gwt/core/
linker and HostedModeTemplate.js in com/google/gwt/core/ext/linker/
impl use document.write to manipulate the HTML page. This is not
allowed in XHTML. I changed
RequestFactoryServlet assumes static methods and data binding is
available to Record that represents an entity (id and version) which
is not always the case, isn't this a bit limiting it seems to be only
tailored to be used with ROO. Some people will still want to use
controller/service classes
Not applied until rev.8404.
A Swing UI shortcut/mnemonic within the GWT Development Mode Shell for:
* Launch Default Browser = Alt + L
* Copy to Clipboard = Alt + C
* Collapse All = Alt + O
* Expand All = Alt + E
...otherwise many devs have to use the mouse all the time — especially
for
Launch
Reviewers: ,
Description:
When more than one RequestFactory is created, we are getting compiling
errors because some of the records are not in the same package than the
actual request factory. To fix this, we simply add all the imports to
the RequestFactoryGenerator in order to know where to
Greetings,
Apologies for the long delay (and the top-post). I've made slow, but
steady progress building a Fedora gwt package (thanks to many others
in the Fedora community who understand Java and Java packaging).
As a recap, the Fedora packaging policy prohibits bundling software in
RPM's. As
On Thu, Jul 22, 2010 at 11:57 AM, James Laska james.la...@gmail.com wrote:
Based on the above failures, I could use some guidance/clarification.
1) I see use of org.eclipse.jdt.internal.*, my understanding is that
these internal objects are not guaranteed to be available in future
versions
Please read the design wave to see our plan to fix this.
https://wave.google.com/wave/waveref/googlewave.com/w+WU4iAICkI
On Thu, Jul 22, 2010 at 1:57 AM, Yazan qet...@gmail.com wrote:
RequestFactoryServlet assumes static methods and data binding is
available to Record that represents an
Thanks for the patch!
We just noticed this ourselves, and a broader patch should soon go in that
includes this fix.
On Thu, Jul 22, 2010 at 7:59 AM, i...@invalidip.com wrote:
Reviewers: ,
Description:
When more than one RequestFactory is created, we are getting compiling
errors because
On Thursday, July 22, 2010 02:01:53 pm Ray Ryan wrote:
Thanks for the patch!
We just noticed this ourselves, and a broader patch should soon go in that
includes this fix.
Great.. are we going to be able to extend a RequestFactory with this
patch? I described the issue there:
Please don't get too attached to EditorSupport. It was a last minute hack
without a lot of thought behind it. A ground-up rewrite is in progress.
We'll share details soon.
RequestFactory too is undergoing surgery, per
https://wave.google.com/wave/waveref/googlewave.com/w+WU4iAICkI
Not that I
Reviewers: conroy,
Description:
Fixing WindowImplIE.getQueryString to look for the first occurence of a
? instead of the last. Similarly fixing WindowImplIE.getHash to look
for the first occurence of # instead of the last. This makes IE
consistent with the standards and other browsers.
LGTM
and to save others the trouble, here's the relevant part of the RFC:
http://www.ietf.org/rfc/rfc3986.txt section 3.4 for reference
The query component contains non-hierarchical data that, along with
data in the path component (Section 3.3), serves to identify a
resource within
http://gwt-code-reviews.appspot.com/707802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
When running the full set of unit tests, I encountered a problem when
SpeedTracerLogger.init() is never called. SpeedTracerLogger.get()
returned null and cased an NPE wherever the code was instrumented.
http://gwt-code-reviews.appspot.com/707802/show
--
On 2010/07/22 21:03:08, zundel wrote:
When running the full set of unit tests, I encountered a problem when
SpeedTracerLogger.init() is never called. SpeedTracerLogger.get()
returned null
and cased an NPE wherever the code was instrumented.
lgtm
http://gwt-code-reviews.appspot.com/710801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for taking the time to right this up. It's really appreciated.
On Wed, Jul 21, 2010 at 6:13 PM, Thomas Broyer t.bro...@gmail.com wrote:
Hi G-Men,
I've started prototyping with Activities and can now give some more
feedback on how it compares to my previous own implementation of a
I just now took a look, and was curious about the rationale for some of
the API changes. In particular, I'm trying to figure out the value of
having to do the extra '.get()' at all call sites, vs. having static
methods that do the '.get()' internally. I see some theoretical value
in being able
Reviewers: Ray Ryan,
Description:
Add support for authentication
Please review this at http://gwt-code-reviews.appspot.com/706802/show
Affected files:
M bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Scaffold.java
M
20 matches
Mail list logo
