[gwt-contrib] Making GWT look good...

2010-08-06 Thread Chris Ramsdale
Hey GWT(ers), I've heard from many of you that GWT apps simply don't look that good out of the box, and styling the default app would go a long way. We couldn't agree more. As some of you know, GWT 2.1 (with the help of Spring Roo 1.1) will generate a full-fledged scaffolding app that users can

[gwt-contrib] Re: Making GWT look good...

2010-08-06 Thread Mathias Bogaert
Google Adwords contains good looking business widgets (buttons, dropdowns, wizards, etc). How about open-sourcing some of those? On Aug 6, 2:44 pm, Chris Ramsdale cramsd...@google.com wrote: Hey GWT(ers), I've heard from many of you that GWT apps simply don't look that good out of the box,

[gwt-contrib] Fixing a couple of typos in JavaDoc. (issue720802)

2010-08-06 Thread jlabanca
Reviewers: Dan Rice, Description: Fixing a couple of typos in JavaDoc. Please review this at http://gwt-code-reviews.appspot.com/720802/show Affected files: M user/src/com/google/gwt/app/place/ActivityManager.java M user/src/com/google/gwt/cell/client/ClickableTextCell.java Index:

[gwt-contrib] Adding missing keyboardSelected styles to CellTable.css sub classes used by ExpenseList and Expe... (issue713803)

2010-08-06 Thread jlabanca
Reviewers: Dan Rice, Description: Adding missing keyboardSelected styles to CellTable.css sub classes used by ExpenseList and ExpenseDetails. Please review this at http://gwt-code-reviews.appspot.com/713803/show Affected files: M

[gwt-contrib] Re: Fixing a couple of typos in JavaDoc. (issue720802)

2010-08-06 Thread rice
LGTM http://gwt-code-reviews.appspot.com/720802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding missing keyboardSelected styles to CellTable.css sub classes used by ExpenseList and Expe... (issue713803)

2010-08-06 Thread rice
LGTM Is there a way to inherit these rather than having to redeclare them in every app? http://gwt-code-reviews.appspot.com/713803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8495 committed - Adding missing keyboardSelected styles to CellTable.css sub classes us...

2010-08-06 Thread codesite-noreply
Revision: 8495 Author: jlaba...@google.com Date: Fri Aug 6 04:02:11 2010 Log: Adding missing keyboardSelected styles to CellTable.css sub classes used by ExpenseList and ExpenseDetails. Review at http://gwt-code-reviews.appspot.com/713803

[gwt-contrib] Re: Adding missing keyboardSelected styles to CellTable.css sub classes used by ExpenseList and Expe... (issue713803)

2010-08-06 Thread jlabanca
I couldn't find a way to inherit them, but its on my TODO list to find out if its possible. http://gwt-code-reviews.appspot.com/713803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8496 committed - De-bounce built-in selection models...

2010-08-06 Thread codesite-noreply
Revision: 8496 Author: r...@google.com Date: Fri Aug 6 06:29:40 2010 Log: De-bounce built-in selection models Review at http://gwt-code-reviews.appspot.com/722802 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8496 Modified:

Re: [gwt-contrib] [google-web-toolkit] r8484 committed - Fix support for null fields and Boolean type types in RequestFactory....

2010-08-06 Thread Pascal Patry
On Friday, August 06, 2010 00:48:34 codesite-nore...@google.com wrote: Revision: 8484 Author: cromwell...@google.com Date: Wed Aug 4 22:08:44 2010 Log: Fix support for null fields and Boolean type types in RequestFactory. Null fix patch by icsy Review at

[gwt-contrib] Re: Enhancement for issue 4870 (issue732801)

2010-08-06 Thread Eric B. Ridge
On Aug 5, 10:38 pm, John Tamplin j...@google.com wrote: How do you know you are getting a serialized exception rather than some random error page returned by the server? This almost sounds rhetorical, but... *I* know I'm getting the serialized exception that my code threw from the RPC

[gwt-contrib] Removed the RequestDataManager class that is no longer used. (issue743801)

2010-08-06 Thread amitmanjhi
Reviewers: cromwellian, Description: Removed the RequestDataManager class that is no longer used. Patch by: amitmanjhi Review by: cromwellian (tbr) Please review this at http://gwt-code-reviews.appspot.com/743801/show Affected files: D

[gwt-contrib] Re: Another step towards making instance methods real. The interface on the client is pretty much wh... (issue710803)

2010-08-06 Thread Amit Manjhi
As we chatted over IM, the RequestDataManager class was not deleted in an earlier patch, as it should have been. Prepared a patch that deletes the class: http://gwt-code-reviews.appspot.com/743801/show On Fri, Aug 6, 2010 at 10:14 AM, cromwell...@google.com wrote:

[gwt-contrib] Re: Adding missing keyboardSelected styles to CellTable.css sub classes used by ExpenseList and Expe... (issue713803)

2010-08-06 Thread jlabanca
committed as r8495 http://gwt-code-reviews.appspot.com/713803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactor SpeedTracerLogger to use Event objects for controlling start/stop (issue704803)

2010-08-06 Thread conroy
http://gwt-code-reviews.appspot.com/704803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

2010-08-06 Thread rjrjr
http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactor SpeedTracerLogger to use Event objects for controlling start/stop (issue704803)

2010-08-06 Thread zundel
LGTM++ http://gwt-code-reviews.appspot.com/704803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix datatype renderers to handle nulls properly for some primitive types. (issue725804)

2010-08-06 Thread amitmanjhi
LGTM http://gwt-code-reviews.appspot.com/725804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8497 committed - Fixing a couple of typos in JavaDoc....

2010-08-06 Thread codesite-noreply
Revision: 8497 Author: jlaba...@google.com Date: Fri Aug 6 11:09:15 2010 Log: Fixing a couple of typos in JavaDoc. Review at http://gwt-code-reviews.appspot.com/720802 Review by: r...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8497 Modified:

[gwt-contrib] Re: Fixing a couple of typos in JavaDoc. (issue720802)

2010-08-06 Thread jlabanca
committed as r8497 http://gwt-code-reviews.appspot.com/720802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: r8484 committed - Fix support for null fields and Boolean type types in RequestFactory....

2010-08-06 Thread pjulien
I'm not having much luck with this patch either. The problem I have is with enums. If I have a record with: PropertyPhoneType phoneType = new EnumPropertyPhoneType(phoneType, PhoneType.class, PhoneType.values()); This works well if the row is created on the server and sent to the client. The

[gwt-contrib] [google-web-toolkit] r8498 committed - Removed the RequestDataManager class that is no longer used....

2010-08-06 Thread codesite-noreply
Revision: 8498 Author: amitman...@google.com Date: Fri Aug 6 11:42:27 2010 Log: Removed the RequestDataManager class that is no longer used. Patch by: amitmanjhi Review by: cromwellian (tbr) Review at http://gwt-code-reviews.appspot.com/743801

[gwt-contrib] [google-web-toolkit] r8499 committed - Remaining changes to bikeshed/scaffold app as a result of using Long i...

2010-08-06 Thread codesite-noreply
Revision: 8499 Author: amitman...@google.com Date: Fri Aug 6 11:47:57 2010 Log: Remaining changes to bikeshed/scaffold app as a result of using Long ids instead of String ids. Patch by: amitmanjhi Review by: cromwellian (tbr) http://code.google.com/p/google-web-toolkit/source/detail?r=8499

Re: [gwt-contrib] Re: r8484 committed - Fix support for null fields and Boolean type types in RequestFactory....

2010-08-06 Thread Ray Cromwell
I'm going to change it to treat undefined as null. In theory, I could change RecordJsoImpl to initialize all property fields to null or a default value, according to JLS semantics, but this just makes the client code bigger, and JSON transfers bigger. Anyone object? -Ray On Fri, Aug 6, 2010 at

Re: [gwt-contrib] Re: r8484 committed - Fix support for null fields and Boolean type types in RequestFactory....

2010-08-06 Thread Pascal Patry
On Friday, August 06, 2010 18:05:04 Ray Cromwell wrote: I'm going to change it to treat undefined as null. In theory, I could change RecordJsoImpl to initialize all property fields to null or a default value, according to JLS semantics, but this just makes the client code bigger, and JSON

[gwt-contrib] Comment on JavaSystemPropertiesAndGwt in google-web-toolkit

2010-08-06 Thread codesite-noreply
Comment by northrup...@gmail.com: please suggest commandline and maven-gwt-plugins switches for 2 core, 4 core, and 8 core workstations For more information: http://code.google.com/p/google-web-toolkit/wiki/JavaSystemPropertiesAndGwt --

[gwt-contrib] Public: Simple implementation of ConstraintViolation, ConstraintDescriptor, Path and Node. (issue735802)

2010-08-06 Thread nchalko
Reviewers: Ray Ryan, Description: Public: Simple implementation of ConstraintViolation, ConstraintDescriptor, Path and Node. Please review this at http://gwt-code-reviews.appspot.com/735802/show Affected files: A user/src/com/google/gwt/validation/client/ConstraintViolationImpl.java A

[gwt-contrib] Re: r8484 committed - Fix support for null fields and Boolean type types in RequestFactory....

2010-08-06 Thread pjulien
I'll take bigger and functional over smaller and throwing exceptions any old day of the week On Aug 6, 6:05 pm, Ray Cromwell cromwell...@gmail.com wrote: I'm going to change it to treat undefined as null. In theory, I could change RecordJsoImpl to initialize all property fields to null or a

[gwt-contrib] Re: Treat undefined Record properties on JSOs as nulls (issue744801)

2010-08-06 Thread Amit Manjhi
LGTM On Fri, Aug 6, 2010 at 3:58 PM, cromwell...@google.com wrote: Reviewers: amitmanjhi, Description: Treat undefined Record properties on JSOs as nulls Please review this at http://gwt-code-reviews.appspot.com/744801/show Affected files: M

[gwt-contrib] [google-web-toolkit] r8501 committed - Treat undefined Record properties on JSOs as nulls...

2010-08-06 Thread codesite-noreply
Revision: 8501 Author: cromwell...@google.com Date: Fri Aug 6 14:02:08 2010 Log: Treat undefined Record properties on JSOs as nulls Review at http://gwt-code-reviews.appspot.com/744801 Review by: amitman...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8501 Modified: