Re: [gwt-contrib] Re: Why does OptionalFieldEditor implements LeafValueEditor?

2010-12-22 Thread Thomas Broyer
On Tue, Dec 21, 2010 at 6:22 PM, Thomas Broyer t.bro...@gmail.com wrote: On Tue, Dec 21, 2010 at 12:29 PM, Thomas Broyer t.bro...@gmail.com wrote: On Mon, Dec 20, 2010 at 5:58 PM, BobV b...@google.com wrote: On Mon, Dec 20, 2010 at 11:44 AM, Thomas Broyer t.bro...@gmail.com wrote: But how do

[gwt-contrib] Too Many Redirects ERROR when signing the Individual CLA

2010-12-22 Thread Luis Solano
Hi I get a TOO MANY REDIRECTS error when trying to signing the Individual Contributor License Agreement. I'm not sure if the record has been added to spreadsheet. - Luis -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] RequestFactory entity proxies can't be cloned

2010-12-22 Thread BobV
Added an issue for this: http://code.google.com/p/google-web-toolkit/issues/detail?id=5794 -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] 2.1.1 fails in SimpleRequestProcessor.processInvocationMessages when no Invokations

2010-12-22 Thread BobV
Added an issue for this: http://code.google.com/p/google-web-toolkit/issues/detail?id=5793 -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9477 committed - Rolling back Generator Result Caching for RPC (issues have been identi...

2010-12-22 Thread codesite-noreply
Revision: 9477 Author: gwt.mirror...@gmail.com Date: Wed Dec 22 07:49:33 2010 Log: Rolling back Generator Result Caching for RPC (issues have been identified) Review at http://gwt-code-reviews.appspot.com/1241801 Review by: zun...@google.com

[gwt-contrib] Fix an NPE in SimpleRequestProcessor when a client request has no invocations. (issue1242801)

2010-12-22 Thread bobv
Reviewers: rchandia, Description: Fix an NPE in SimpleRequestProcessor when a client request has no invocations. Issue 5793. Patch by: bobv Review by: rchandia Found by: cory.prowse Please review this at http://gwt-code-reviews.appspot.com/1242801/show Affected files: M

[gwt-contrib] Re: Fix an NPE in SimpleRequestProcessor when a client request has no invocations. (issue1242801)

2010-12-22 Thread rchandia
LGTM On 2010/12/22 16:37:51, bobv wrote: http://gwt-code-reviews.appspot.com/1242801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Ensure that enum types reachable through AutoBean method parameterizations are included in the E... (issue1240801)

2010-12-22 Thread jbrosenberg
LGTM with nits/suggestions http://gwt-code-reviews.appspot.com/1240801/diff/1/3 File user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java (right): http://gwt-code-reviews.appspot.com/1240801/diff/1/3#newcode201 user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java:201:

[gwt-contrib] Generator Result Caching for RPC, with some refinements to the underlying framework (issue1243801)

2010-12-22 Thread jbrosenberg
Reviewers: zundel, tobyr, Description: Generator Result Caching for RPC, with some refinements to the underlying framework Please review this at http://gwt-code-reviews.appspot.com/1243801/show Affected files: A dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java M

[gwt-contrib] [google-web-toolkit] r9478 committed - Edited wiki page BeanValidation through web user interface.

2010-12-22 Thread codesite-noreply
Revision: 9478 Author: ncha...@google.com Date: Wed Dec 22 10:25:25 2010 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9478 Modified: /wiki/BeanValidation.wiki === ---

[gwt-contrib] Re: Adding column sorting support to CellTable. Clicking on a header of a sortable Column in CellTab... (issue1237801)

2010-12-22 Thread pdr
On 2010/12/20 22:12:00, jlabanca wrote: Do you still need to re-sort after a removal? http://gwt-code-reviews.appspot.com/1237801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding column sorting support to CellTable. Clicking on a header of a sortable Column in CellTab... (issue1237801)

2010-12-22 Thread pdr
LGTM http://gwt-code-reviews.appspot.com/1237801/diff/1/14 File user/test/com/google/gwt/user/cellview/client/ColumnSortListTest.java (right): http://gwt-code-reviews.appspot.com/1237801/diff/1/14#newcode64 user/test/com/google/gwt/user/cellview/client/ColumnSortListTest.java:64: // Compare

[gwt-contrib] Mark test as Failing or NotSupported (issue1245801)

2010-12-22 Thread nchalko
Reviewers: rchandia, Description: Mark test as Failing or NotSupported These are reflected in the tck report numbers. Failing and NotSupported tests are not run by default. This will allow me to move these test into the normal user/test dir and have them run during by the continous build

[gwt-contrib] Add support for selecting messages based on arbitrary values, such (issue1246801)

2010-12-22 Thread jat
Reviewers: pdr, Description: Add support for selecting messages based on arbitrary values, such as gender of a placeholder. Also, add support for more than one @PluralCount / @Select on a given message, in any mix. Patch by: jat Review by: pdr Please review this at

[gwt-contrib] Re: Add support for selecting messages based on arbitrary values, such (issue1246801)

2010-12-22 Thread jat
http://gwt-code-reviews.appspot.com/1246801/diff/1/2 File user/src/com/google/gwt/i18n/client/Messages.java (right): http://gwt-code-reviews.appspot.com/1246801/diff/1/2#newcode384 user/src/com/google/gwt/i18n/client/Messages.java:384: @Deprecated I debated deprecating this, and could be

[gwt-contrib] Add support for arbitrary units in SplitLayoutPanel (issue1244801)

2010-12-22 Thread fmalita
Reviewers: zundel, jgw, jlabanca, Description: Add support for arbitrary units in SplitLayoutPanel Please review this at http://gwt-code-reviews.appspot.com/1244801/show Affected files: M user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java Index:

[gwt-contrib] Re: Comment on TroubleshootingOOPHM in google-web-toolkit

2010-12-22 Thread codesite-noreply
Comment by WLiu1976: Finally make it work on Chrome. The most important thing is to allow the external web server in the GWT developer plugin. More details see: http://notepad2.blogspot.com/2010/12/debug-google-web-toolkit-applications.html For more information:

[gwt-contrib] Use instanceof to find the right top level GwtSpecificValidator. (issue1239802)

2010-12-22 Thread nchalko
Reviewers: rchandia, Description: Use instanceof to find the right top level GwtSpecificValidator. This allows sub classes and Proxies like those generated by RequestFactory to be validated [JSR 303 TCK Result] 53 of 258 (20.54%) Pass with 28 Failures and 13 Errors. Please review this at