Revision: 10202
Author: gwt.mirror...@gmail.com
Date: Mon May 23 07:26:25 2011
Log: Enables on the persistent unit cache by default.
Review at http://gwt-code-reviews.appspot.com/1448801
http://code.google.com/p/google-web-toolkit/source/detail?r=10202
Modified:
http://gwt-code-reviews.appspot.com/1442807/diff/4001/dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
http://gwt-code-reviews.appspot.com/1442807/diff/4001/dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
PTAL
http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1436802/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1436802/diff/4001/dev/core/test/com/google/gwt/dev/jjs/impl/PrunerTest.java
File dev/core/test/com/google/gwt/dev/jjs/impl/PrunerTest.java (right):
Reviewers: zundel,
Description:
Partial fix for buganizer issue 4466425. Created a method to shift the
expression range indices for the detailed SOYC reports after function
clustering.
Please review this at http://gwt-code-reviews.appspot.com/1451801/
Affected files:
M
We're trying to make bindery the correct location, but we're a bit in
mid-step.
But you shouldn't have to have two instances. gwt...EventBus extends
binder...EventBus.
On Sun, May 22, 2011 at 10:29 AM, dd cafeb...@googlemail.com wrote:
Hey g-men,
with GWT 2.3 the autobean, event and
http://gwt-code-reviews.appspot.com/1442807/diff/4001/dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(left):
http://gwt-code-reviews.appspot.com/1451801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
Comment re: clusterer below. Working on the formatting now...
On Mon, May 23, 2011 at 2:07 PM, zun...@google.com wrote:
http://gwt-code-reviews.appspot.com/1451801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File
@Bobv
One thing about RequestFactoryServlet is that it is somewhat difficult to
setup DI from containers such as Spring. I've been working on getting Spring
wired into the request factory framework and there are a bunch of examples,
but they all are pretty ugly. I think I've found a fairly
Nearly there, just a couple of nits. Thanks!
After this patch lands we're going to need to think harder about the
testing. The coverage introduced here is pretty light. E.g., we're not
reproducing any of the escaping checks (like the various
test*FunnyChars tests in UiBinderTest. I don't have an
DocumentModeAsserter is asserting that the Document.compatMode does not
equal BackCompat, which corresponds to quirks mode. You should be
able to use any variation of the strict mode doctype and still pass the
asserter, as long as the Document.compatMode is CSS1Compat. If your app
is in quirks
http://gwt-code-reviews.appspot.com/1436802/diff/4001/dev/core/test/com/google/gwt/dev/jjs/impl/PrunerTest.java
File dev/core/test/com/google/gwt/dev/jjs/impl/PrunerTest.java (right):
Does it makes sense
to add the ServletContext into RequestFactoryServlet inside GWT proper? If
so, I can submit a patch for you.
That sounds like a very clean approach. When you submit the patch,
please create an issue in the GWT issue tracker with the URL of the
code review.
--
Bob Vawter
http://gwt-code-reviews.appspot.com/1422812/diff/7001/user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java
File
user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java
(right):
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
LGTM
Woot!
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
File
user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1447806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10203
Author: sco...@google.com
Date: Mon May 23 09:42:46 2011
Log: Pruner runs only once.
I know this feels a little hacky, but I tracked down most of the sources of
Pruner jitter that's causing it to run more than once.
1) Instance fields needed to be treated like
LGTM
http://gwt-code-reviews.appspot.com/1442807/diff/4001/dev/core/src/com/google/gwt/dev/js/JsUnusedFunctionRemover.java
File dev/core/src/com/google/gwt/dev/js/JsUnusedFunctionRemover.java
(left):
Hello,
I run into a case when I want to have different classpath for running
gwtc (through com.google.gwt.dev.Compiler class) from classpath
containing source code that gwtc would compile.
Let me give you a specific scenario. My fork of gwt is using
scala-library.jar of some version A for
Reviewers: jlabanca,
Description:
Public (steph...@gmail.com):
Adds two protected static methods to EventBus that expose otherwise
inaccessible methods on Event (setSource and dispatch) to subclasses
of EventBus. Allows alternative EventBus implementations without
muddying the public API events
Tweaks in http://gwt-code-reviews.appspot.com/1450802
http://gwt-code-reviews.appspot.com/1443804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi GWT Devs,
I've recently come across Issue 6153
(http://code.google.com/p/google-web-toolkit/issues/detail?id=6153) which
affects the released version of GWT 2.3. Any chance of a patch or a release
2.3.1 to fix this? Automatic error reporting integrated with the editor
framework is probably
http://gwt-code-reviews.appspot.com/1451801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
Hi Grzegorz,
You mentioned the compiled classes in the class path are used to
populate the type orace. For the most part, the type oracle types are
compiled from source. Types that don't have source are then checked
to see if they are binary annotations and then a type oracle reference
is
Revision: 10204
Author: fre...@google.com
Date: Mon May 23 11:13:45 2011
Log: - Modify the default HTML template to indicate that quirks mode
is not supported
- Cleanup UserAgentGenerator.java, for consistency with
DocumentModeGenerator.java
- Add two new configuration properties:
Reviewers: bobv, google-web-toolkit-contributors_googlegroups.com,
Description:
Adds a ThreadLocalServletContext which will make it easier to
facilitate getting beans from Spring.
Please review this at http://gwt-code-reviews.appspot.com/1448804/
Affected files:
Created the issue as well and posted a link to the review.
Thanks!
http://gwt-code-reviews.appspot.com/1448804/
http://code.google.com/p/google-web-toolkit/issues/list?cursor=6393updated=6393ts=1306206518
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Oh and I did test this to make sure it would with Spring. If you're
interested here is a link to my test project.
https://github.com/larsenje/SpringRequestFactoryExample
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10205
Author: rdcas...@google.com
Date: Mon May 23 17:23:56 2011
Log: Attachable-IsRenderable rename step 1: Renaming the base
interface.
Review at http://gwt-code-reviews.appspot.com/1447806
http://code.google.com/p/google-web-toolkit/source/detail?r=10205
Added:
35 matches
Mail list logo
