[gwt-contrib] Re: Small fix to CellPanelParser to make it work with lazy widget (issue1577803)

2011-10-20 Thread rchandia
LGTM! http://gwt-code-reviews.appspot.com/1577803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

2011-10-20 Thread skybrian
The design seems a bit opaque - I'm having trouble following what the invariants are and what's going on with the concurrency. Can you explain it a bit more? http://gwt-code-reviews.appspot.com/1490801/diff/11002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File

[gwt-contrib] Restores r10697 now that the CellPanelParser fixes are in place (issue1578803)

2011-10-20 Thread rjrjr
Reviewers: rchandia, Description: Restores r10697 now that the CellPanelParser fixes are in place *** Original change description *** Change default of UiBinder.useLazyWidgetBuilders to true, in preparation for deleting the old code. Also fixes unreported bad code gen for things like a

[gwt-contrib] Re: Restores r10697 now that the CellPanelParser fixes are in place (issue1578803)

2011-10-20 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1578803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

2011-10-20 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1490801/diff/11002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (right):

[gwt-contrib] Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-20 Thread skybrian
Reviewers: tobyr, Description: Switch to internal implementation of StringInterner to avoid class loader leaks when reloading the page in dev mode. (Not tuned.) Please review this at http://gwt-code-reviews.appspot.com/1578804/ Affected files: M

[gwt-contrib] Re: Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-20 Thread tobyr
http://gwt-code-reviews.appspot.com/1578804/diff/1/dev/core/src/com/google/gwt/dev/util/StringInterner.java File dev/core/src/com/google/gwt/dev/util/StringInterner.java (right):

[gwt-contrib] Re: Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-20 Thread skybrian
http://gwt-code-reviews.appspot.com/1578804/diff/1/dev/core/src/com/google/gwt/dev/util/StringInterner.java File dev/core/src/com/google/gwt/dev/util/StringInterner.java (right):

[gwt-contrib] Keeps LazyPanelParser from breaking existing templates that use (issue1577804)

2011-10-20 Thread rjrjr
Reviewers: rchandia, Description: Keeps LazyPanelParser from breaking existing templates that use @UiField(provided = true) to get LazyPanels into templates. Please review this at http://gwt-code-reviews.appspot.com/1577804/ Affected files: M

[gwt-contrib] Re: Switch to internal implementation of StringInterner to avoid class loader (issue1578804)

2011-10-20 Thread tobyr
http://gwt-code-reviews.appspot.com/1578804/diff/1/dev/core/src/com/google/gwt/dev/util/StringInterner.java File dev/core/src/com/google/gwt/dev/util/StringInterner.java (right):