[gwt-contrib] Re: Add support for soft permutations to SingleScriptLinker. (issue1678803)

LGTM It seems like there should be some test for this to make sure it keeps working. Could you extend SingleScriptLinkerTest to make sure that it handles collapsing soft permutations? http://gwt-code-reviews.appspot.com/1678803/ --

[gwt-contrib] Fix PopupPanel.center when content has changed (issue1573803)

Looks good to me, but I'd like John to take a look. http://gwt-code-reviews.appspot.com/1573803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix dtd for collapse-property (issue1580804)

LGTM. http://gwt-code-reviews.appspot.com/1580804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add font-face support to CssResource. (issue1502806)

On 2012/04/05 21:33:43, acleung wrote: On 2011/11/14 08:51:56, tbroyer wrote: On 2011/07/28 21:11:18, unnurg wrote: LGTM It's been more than 3 months and still not committed :-( bobv has left Google for other quests and adventures. I'll pick up this change and submit it.

[gwt-contrib] Re: Use one common implementation of UserAgentProperty when runtime (issue1680803)

LGTM http://gwt-code-reviews.appspot.com/1680803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix dtd for collapse-property (issue1580804)

On 2012/04/05 21:55:42, rdayal wrote: LGTM. Submitted. http://gwt-code-reviews.appspot.com/1580804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

Submitted. http://gwt-code-reviews.appspot.com/1582803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] - String conversions. (issue1632803)

On 2012/04/05 18:59:13, rdayal wrote: Jason, can you look at this one more time? Sorry about the delay. Had to make a couple of changes: 1) You can't map null values in a ConcurrentHashMap. Bad suggestion on my part. 2) It's a change in behavior to pass null into readContent. Changed this to

[gwt-contrib] Add missing DOMImplIE8.cssClearOpacity (issue1615805)

LGTM. http://gwt-code-reviews.appspot.com/1615805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add support for soft permutations to SingleScriptLinker. (issue1678803)

LGTM http://gwt-code-reviews.appspot.com/1678803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix PopupPanel.center when content has changed (issue1573803)

On 2012/04/06 15:00:31, rdayal wrote: Thanks! On Fri Apr 06 10:52:30 GMT-400 2012, mailto:jlaba...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/1573803/%3Chttps://www.google.com/url?sa=Dq=http://gwt-code-reviews.appspot.com/1573803/ Submitted.

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

On 2012/04/05 19:39:54, rdayal wrote: Ping. Is this patch dead, or do we still want to get this in? I remember that we were not able to push it into release (2.4 ?). But this problem is still causing problems in GWT Designer. http://gwt-code-reviews.appspot.com/1490801/ --

Re: [gwt-contrib] Bean Validation status / future plans?

There is another project that seems to be more advanced than current status: http://code.google.com/p/gwt-validation/ ¿Is there a chance to include it's work? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6331: Let AutoBean accept numbers for dates and longs (issue1601805)

Ping. Brian, can you take a final look at this? http://gwt-code-reviews.appspot.com/1601805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add font-face support to CssResource. (issue1502806)

On 2011/11/14 08:51:56, tbroyer wrote: On 2011/07/28 21:11:18, unnurg wrote: LGTM It's been more than 3 months and still not committed :-( bobv has left Google for other quests and adventures. I'll pick up this change and submit it. http://gwt-code-reviews.appspot.com/1502806/ --

[gwt-contrib] Re: Add support for @font-face CSS declarations. (issue1679803)

http://gwt-code-reviews.appspot.com/1679803/diff/1/user/src/com/google/gwt/resources/css/ast/CssFontFace.java File user/src/com/google/gwt/resources/css/ast/CssFontFace.java (right):

[gwt-contrib] Re: Add missing DOMImplIE8.cssClearOpacity (issue1615805)

On 2012/04/06 18:44:50, rdayal wrote: LGTM. Submitted. http://gwt-code-reviews.appspot.com/1615805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

Looks like this one is not going to be accepted. @portersi: If you could close this issue, that would be great. http://gwt-code-reviews.appspot.com/1503806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add StyleInjector.flush (issue1614806)

LGTM http://gwt-code-reviews.appspot.com/1614806/diff/1/user/src/com/google/gwt/dom/client/StyleInjector.java File user/src/com/google/gwt/dom/client/StyleInjector.java (right): http://gwt-code-reviews.appspot.com/1614806/diff/1/user/src/com/google/gwt/dom/client/StyleInjector.java#newcode219

[gwt-contrib] Re: Fix initialization of non-final fields (issue1618807)

@cromwellian: Can you take another look so we can get this in? http://gwt-code-reviews.appspot.com/1618807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6331: Let AutoBean accept numbers for dates and longs (issue1601805)

http://gwt-code-reviews.appspot.com/1601805/diff/2004/user/src/com/google/web/bindery/autobean/shared/ValueCodex.java File user/src/com/google/web/bindery/autobean/shared/ValueCodex.java (right):

[gwt-contrib] Re: Add support for @font-face CSS declarations. (issue1679803)

On 2012/04/05 21:42:05, acleung wrote: Copied from: http://gwt-code-reviews.appspot.com/1502806/ http://gwt-code-reviews.appspot.com/1679803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

On 2012/04/05 19:44:18, rdayal wrote: We're gearing up for a GWT 2.5, so I'd either like to get this in, or close the issue if it will never make it into a GWT release. On Thu Apr 05 15:42:05 GMT-400 2012, mailto:scheg...@google.com wrote: On 2012/04/05 19:39:54, rdayal wrote: Ping.

[gwt-contrib] Re: Fix SC_GATEWAY_TIMEOUT typo (issue1618805)

On 2012/04/06 18:30:56, rdayal wrote: On 2011/12/17 07:00:31, stephenh wrote: LGTM. Submitted. http://gwt-code-reviews.appspot.com/1618805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make GWT.create/etc usable on server. (issue1677803)

http://gwt-code-reviews.appspot.com/1677803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] - String conversions. (issue1632803)

http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add assert for null provided fields, fixes #7024 (issue1602805)

Great, thanks! http://gwt-code-reviews.appspot.com/1602805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add support for @font-face CSS declarations. (issue1679803)

Reviewers: rdayal, Description: Add support for @font-face CSS declarations. Please review this at http://gwt-code-reviews.appspot.com/1679803/ Affected files: M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java M user/src/com/google/gwt/resources/css/GenerateCssAst.java A

[gwt-contrib] Re: Add support for @font-face CSS declarations. (issue1679803)

LGTM. http://gwt-code-reviews.appspot.com/1679803/diff/1/user/src/com/google/gwt/resources/css/ast/CssFontFace.java File user/src/com/google/gwt/resources/css/ast/CssFontFace.java (right):

[gwt-contrib] Re: Issue 6331: Let AutoBean accept numbers for dates and longs (issue1601805)

Hi, I think it's sufficient to test the happy path for the range that currently works and defer testing error conditions for some other time. The point is to make sure we don't accidentally regress to a smaller range and break an app that starts relying on the fix that you've added.

[gwt-contrib] Re: Add assert for null provided fields, fixes #7024 (issue1602805)

On 2012/04/05 19:55:44, rdayal wrote: Rodrigo, has this been submitted? Yes. Submitted as of r10783 http://gwt-code-reviews.appspot.com/1602805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

Ping. Can we get this review wrapped up? I'd like to push this into GWT 2.5 (or close the issue completely, if not). http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add assert for null provided fields, fixes #7024 (issue1602805)

Rodrigo, has this been submitted? http://gwt-code-reviews.appspot.com/1602805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors