Re: [gwt-contrib] tests

2012-06-20 Thread John Tamplin
On Wed, Jun 20, 2012 at 6:48 AM, Eric Ayers zun...@google.com wrote: Now, the problem with diagnosing this is that the file is set to be deleted on exit. So after the program exits, you can't see how ridiculously huge the file might have been. To test that theory, you could try commenting

[gwt-contrib] Fix requestfactory test errors, and compilation failures in dev/compile.test resulting from the ... (issue1743808)

2012-06-20 Thread rdayal
Reviewers: tbroyer, skybrian, Description: Fix requestfactory test errors, and compilation failures in dev/compile.test resulting from the unbund ling of streamhtmlparser. Please review this at http://gwt-code-reviews.appspot.com/1743808/ Affected files: M dev/build.xml M

[gwt-contrib] Increase heap size for testing to prevent GC thrashing and OOMs when running usr/BigIntegerSuite. (issue1750803)

2012-06-20 Thread rdayal
Reviewers: skybrian, Description: Increase heap size for testing to prevent GC thrashing and OOMs when running usr/BigIntegerSuite. Please review this at http://gwt-code-reviews.appspot.com/1750803/ Affected files: M common.ant.xml Index: common.ant.xml

[gwt-contrib] Re: Increase heap size for testing to prevent GC thrashing and OOMs when running usr/BigIntegerSuite. (issue1750803)

2012-06-20 Thread rdayal
http://gwt-code-reviews.appspot.com/1750803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added ElementType to ConstraintDescriptors and ConstraintViolations. Used ElementType to handle ... (issue1746803)

2012-06-20 Thread nchalko
http://gwt-code-reviews.appspot.com/1746803/diff/6001/user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java File user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java (right):

[gwt-contrib] Re: Increase heap size for testing to prevent GC thrashing and OOMs when running usr/BigIntegerSuite. (issue1750803)

2012-06-20 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1750803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Extracted constant strings to the constructor, that allow translation to be provided from the ou... (issue1739803)

2012-06-20 Thread jlabanca
committed as r11095 http://gwt-code-reviews.appspot.com/1739803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Use Node.contains in IE9/Webkit for isOrHasChild (issue1725808)

2012-06-20 Thread jlabanca
LGTM I'm running tests and committing this now. http://gwt-code-reviews.appspot.com/1725808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Added 5 missing tests to the TCK test suite coverage. (issue1744804)

2012-06-20 Thread idol
Reviewers: Nick Chalko, Description: Added 5 missing tests to the TCK test suite coverage. Please review this at http://gwt-code-reviews.appspot.com/1744804/ Affected files: M user/test/com/google/gwt/validation/tck/ConstraintCompositionGwtSuite.java M

[gwt-contrib] Re: Added 5 missing tests to the TCK test suite coverage. (issue1744804)

2012-06-20 Thread nchalko
LGTM http://gwt-code-reviews.appspot.com/1744804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix requestfactory test errors, and compilation failures in dev/compile.test resulting from the ... (issue1743808)

2012-06-20 Thread t . broyer
LGTM http://gwt-code-reviews.appspot.com/1743808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Move test Messages files from client to shared; was missed in r10061. This was causing I18NSuite... (issue1752803)

2012-06-20 Thread rdayal
Reviewers: jat, Description: Move test Messages files from client to shared; was missed in r10061. This was causing I18NSuite to fail. Please review this at http://gwt-code-reviews.appspot.com/1752803/ Affected files: D

[gwt-contrib] Re: Move test Messages files from client to shared; was missed in r10061. This was causing I18NSuite... (issue1752803)

2012-06-20 Thread jat
LGTM Thanks for tracking this down and fixing it. http://gwt-code-reviews.appspot.com/1752803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move test Messages files from client to shared; was missed in r10061. This was causing I18NSuite... (issue1752803)

2012-06-20 Thread Rajeev Dayal
No prob, thx for your help in doing so :). On Wed, Jun 20, 2012 at 7:38 PM, j...@google.com wrote: LGTM Thanks for tracking this down and fixing it. http://gwt-code-reviews.**appspot.com/1752803/http://gwt-code-reviews.appspot.com/1752803/ --

[gwt-contrib] Re: Added ElementType to ConstraintDescriptors and ConstraintViolations. Used ElementType to handle ... (issue1746803)

2012-06-20 Thread idol
http://gwt-code-reviews.appspot.com/1746803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added ElementType to ConstraintDescriptors and ConstraintViolations. Used ElementType to handle ... (issue1746803)

2012-06-20 Thread idol
http://gwt-code-reviews.appspot.com/1746803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix violations generated by properties with constraints on both getters and fields (issue1746803)

2012-06-20 Thread idol
On 2012/06/21 00:00:43, David Idol wrote: Patches 3 and 4 are identical. I was attempting to update the issue's description and accidentally submitted the code again. http://gwt-code-reviews.appspot.com/1746803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors