[gwt-contrib] Re: fixes ISSUE 7479 (typo in javadoc) (issue1770803)

2012-07-30 Thread rdayal
On 2012/07/04 21:47:12, kurka.daniel wrote: Simply typo in javadoc needs review LGTM. http://gwt-code-reviews.appspot.com/1770803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added support for group sequences - including Default group overrides. (issue1798803)

2012-07-30 Thread nchalko
Partial review. More to follow http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java File user/src/com/google/gwt/validation/client/Group.java (right):

[gwt-contrib] Increase a timeout in JsonpRequestSuite to see if it fixes a flaky test. (issue1798804)

2012-07-30 Thread skybrian
Reviewers: cromwellian, Description: Increase a timeout in JsonpRequestSuite to see if it fixes a flaky test. (It seems to help when running the tests by hand, but it's hard to tell.) Please review this at http://gwt-code-reviews.appspot.com/1798804/ Affected files: M

[gwt-contrib] Re: Make ScriptInjectorTest less flaky by referencing locally-served test data. (issue1800803)

2012-07-30 Thread skybrian
http://gwt-code-reviews.appspot.com/1800803/diff/1/user/test/com/google/gwt/core/public/script_injector_test_absolute.js File user/test/com/google/gwt/core/public/script_injector_test_absolute.js (right):