[gwt-contrib] Re: Implemented assertArrayEquals method for client side JUnit testing. (issue1805803)

2012-08-07 Thread nchalko
lgtm http://gwt-code-reviews.appspot.com/1805803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Implemented assertArrayEquals method for client side JUnit testing. (issue1805803)

2012-08-07 Thread idol
Reviewers: Nick Chalko, Description: Implemented assertArrayEquals method for client side JUnit testing. [JSR 303 TCK Result] 189 of 205 (92.20%) Pass with 13 Failures and 2 Errors. Please review this at http://gwt-code-reviews.appspot.com/1805803/ Affected files: M user/test-super/org/test

[gwt-contrib] Re: Rename RoletypeRole to Role and improve the javadoc. Subtypes of Role now (issue1799804)

2012-08-07 Thread skybrian
http://gwt-code-reviews.appspot.com/1799804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added Aria roles and properties to the CellTree (issue1776803)

2012-08-07 Thread skybrian
This looks good, other than the corner case for a leaf that used to be a parent. http://gwt-code-reviews.appspot.com/1776803/diff/8001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right): http://gwt-

Re: [gwt-contrib] submit chrome dev mode plugin to chrome web store?

2012-08-07 Thread Rajeev Dayal
Hey Daniel, We do need to post the chrome devmode plugin to the webstore. I'll take care of that this week. I also need to rebuild the devmode plugin, as there were some fixes that went into it a while back that were never put into a distributable binary. Rajeev On Mon, Aug 6, 2012 at 6:53 PM,