[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1806803)

2012-08-14 Thread drfibonacci
When I patch this in and configure Eclipse as instructed in the README, I still get The RequestFactory ValidationTool must be run... error when I launch from Eclipse or mvn gwt:run. http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml

[gwt-contrib] Re: Fix a problem that popups don't close on iPads. (issue1810803)

2012-08-14 Thread skybrian
Okay, you fixed autohide. They also mentioned that DialogBox can't be dragged. Does this change fix that problem too? http://gwt-code-reviews.appspot.com/1810803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add role=presentation into textbox of FocusPanel. (issue1803804)

2012-08-14 Thread skybrian
I'm not familiar with FocusPanel, but it looks like it's used by a variety of subclasses that need to accept keyboard input for various reasons. So I don't think this is a good idea in all cases. Perhaps FocusPanel needs a way to set the ARIA role and you should do this only for your app?

[gwt-contrib] Re: Fix a problem that popups don't close on iPads. (issue1810803)

2012-08-14 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1810803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add role=presentation into textbox of FocusPanel. (issue1803804)

2012-08-14 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1803804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add setComparator to allow custom sorting of candidates from search. (issue1807805)

2012-08-14 Thread jat
On 2012/08/15 00:27:19, skybrian wrote: Looks good. I was wondering whether the sort would be slower, but I looked at the implementation and it's not using native sort() in any case. Let's wait until tomorrow to submit, to give people a chance to respond. LGTM Just adding a comparator