http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
I see, it's probably perfectly applicable to Travis CI (I would just
start the phantomjs webdriver server before executing tests) but what about:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7768
Am 15.01.2013 02:29, schrieb Thomas Broyer:
Note that, while probably not
Daniel Kurka has abandoned this change.
Change subject: simple typo
..
Abandoned
commited
--
To view, visit https://gwt-review.googlesource.com/1730
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Daniel Kurka has abandoned this change.
Change subject: updated javadoc n DeckPanel.getVisibleWidget() fixes issue
7680
..
Abandoned
commited
--
To view, visit https://gwt-review.googlesource.com/1720
To unsubscribe,
Daniel Kurka has abandoned this change.
Change subject: AbstractMap.remove() is incorrect, accessing entry after
deletion fixes issue 7856
..
Abandoned
commited
--
To view, visit https://gwt-review.googlesource.com/1740
On Tuesday, January 15, 2013 10:27:57 AM UTC+1, Maik Riechert wrote:
I see, it's probably perfectly applicable to Travis CI (I would just
start the phantomjs webdriver server before executing tests) but what about:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7768
Ah,
Anything I can do with https://codereview.appspot.com/6132056/ to help get
it ready to go out with whatever release is deemed appropriate?
On 13 January 2013 18:24, Patrick Tucker tucker...@gmail.com wrote:
Any chance these can get committed?
http://gwt-code-reviews.appspot.com/1876803/
On Tuesday, January 15, 2013 12:02:54 PM UTC+1, James Horsley wrote:
Anything I can do with https://codereview.appspot.com/6132056/ to help
get it ready to go out with whatever release is deemed appropriate?
Won't make it to 2.5.1 sorry. For the next release after 2.5.1, my first
task is
Hello Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1750
to look at the new patch set (#5).
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Daniel Kurka has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 5:
nit picking
--
To view, visit https://gwt-review.googlesource.com/1750
To unsubscribe,
Thomas Broyer has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 5:
IIUC, the test as written now would timeout without the fix, right? It
might be worth
Daniel Kurka has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 5:
Where would we document that?
--
To view, visit https://gwt-review.googlesource.com/1750
Thomas Broyer has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 5:
For me, it would be enough to add to the never expire comment; somethin
like: never
Matthew Dempsky has abandoned this change.
Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity
..
Abandoned
Submitted, thanks!
--
To view, visit https://gwt-review.googlesource.com/1670
To unsubscribe, visit
Matthew Dempsky has abandoned this change.
Change subject: increased zIndex of compile dialog to avoid it being hidden
..
Abandoned
Submitted, thanks!
--
To view, visit https://gwt-review.googlesource.com/1530
To
Matthew Dempsky has abandoned this change.
Change subject: use java.net.HttpCookie instead of Crockfords json.org
..
Abandoned
Submitted, thanks!
--
To view, visit https://gwt-review.googlesource.com/1600
To unsubscribe,
Hello Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1750
to look at the new patch set (#6).
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Andrew Bachmann has posted comments on this change.
Change subject: Update to use ICU4J 50.1.1
..
Patch Set 2: Code-Review+1
To clarify, my pending patch is to update the gwt tools for the current
CLDR (22.1). Public
Andrew Bachmann has posted comments on this change.
Change subject: Update to use ICU4J 50.1.1
..
Patch Set 2:
(1 comment)
File eclipse/tools/cldr-import/.classpath
Line
Goktug Gokdogan has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 6:
Hi Daniel.
Did you see my previous comment?
--
To view, visit
Daniel Kurka has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 6:
I actually replied on it: The repeating command needs to be run a second
time to be in
Daniel Kurka has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 6:
my bad: I did not publish it, I am new to gerrit, sorry!
--
To view, visit
Goktug Gokdogan has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 6:
Now I see what you are doing. Just a nit but perhaps you can add a comment
to
Hello Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1750
to look at the new patch set (#7).
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Daniel Kurka has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 7:
Added the comment.
I prefer not to call a private function here and test this via a
Goktug Gokdogan has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 7: Code-Review+1
That is fair. Thanks for fixing it.
--
To view, visit
Am 15.01.2013 11:22, schrieb Thomas Broyer:
On Tuesday, January 15, 2013 10:27:57 AM UTC+1, Maik Riechert wrote:
I see, it's probably perfectly applicable to Travis CI (I would
just start the phantomjs webdriver server before executing tests)
but what about:
Daniel Kurka has posted comments on this change.
Change subject: use java.net.HttpCookie instead of Crockfords json.org
..
Patch Set 2:
no worries this is committed and will be included in GWT 2.5.1 (see
Matthews comment)
Seems fine. (I'll take care of these nits.)
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):
Hi Patrick,
thanks for putting in the work, it's really appreciated!
I have added the reviews to the list for GWT 2.5.1, there is no guarantee that
everything will land in GWT 2.5.1, but at least someone will take a look.
Do you have an open issue for
Brian Slesinsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 1:
(1 comment)
File
31 matches
Mail list logo
