[gwt-contrib] Change in gwt[master]: Remove unnecessary wrapping of IOException in DiskCacheToken...

2013-02-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Remove unnecessary wrapping of IOException in DiskCacheToken. This just increases stack trace verbosity, since the callers either throw IOException already or could easily do so.

[gwt-contrib] Change in gwt[master]: Introduces a common SerializableThrowable and refactors Stac...

2013-02-28 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Introduces a common SerializableThrowable and refactors StackTraceDeobfuscator as public API. .. Patch Set 1: (3 comments)

[gwt-contrib] Change in gwt[master]: Cleans up few remaning issues from recent clean up in test i...

2013-02-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Cleans up few remaning issues from recent clean up in test infra. .. Patch Set 1: Code-Review+1 (1 comment)

[gwt-contrib] Change in gwt[master]: Introduces a common SerializableThrowable and refactors Stac...

2013-02-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Introduces a common SerializableThrowable and refactors StackTraceDeobfuscator as public API. .. Patch Set 1: (1 comment)

[gwt-contrib] Change in gwt[master]: Cleans up few remaning issues from recent clean up in test i...

2013-02-28 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Cleans up few remaning issues from recent clean up in test infra. .. Patch Set 1: (1 comment) File

[gwt-contrib] Change in gwt[master]: Adds java reflection based GWTRunnerProxy implementation.

2013-02-28 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/2032 Change subject: Adds java reflection based GWTRunnerProxy implementation. .. Adds java reflection based GWTRunnerProxy

[gwt-contrib] Change in gwt[master]: Adds java reflection based GWTRunnerProxy implementation.

2013-02-28 Thread John A. Tamplin
John A. Tamplin has posted comments on this change. Change subject: Adds java reflection based GWTRunnerProxy implementation. .. Patch Set 1: There are so few test invocations and they take so little time compared to the

[gwt-contrib] Change in gwt[master]: Introduces a common SerializableThrowable and refactors Stac...

2013-02-28 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Introduces a common SerializableThrowable and refactors StackTraceDeobfuscator as public API. .. Patch Set 1: (4 comments)

[gwt-contrib] Change in gwt[master]: Introduces a common SerializableThrowable and refactors Stac...

2013-02-28 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new patch set (#2). Change subject: Introduces a common SerializableThrowable and refactors StackTraceDeobfuscator as public API. .. Introduces a common SerializableThrowable and refactors

[gwt-contrib] Change in gwt[master]: Remove unnecessary wrapping of IOException in DiskCacheToken...

2013-02-28 Thread Brian Slesinsky
Brian Slesinsky has uploaded a new patch set (#2). Change subject: Remove unnecessary wrapping of IOException in DiskCacheToken. Instead, catch the exception at the artifact level and log it with some context. .. Remove

[gwt-contrib] Change in gwt[master]: Remove unnecessary wrapping of IOException in DiskCacheToken...

2013-02-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Remove unnecessary wrapping of IOException in DiskCacheToken. Instead, catch the exception at the artifact level and log it with some context. .. Patch

[gwt-contrib] Change in gwt[master]: Adds java reflection based GWTRunnerProxy implementation.

2013-02-28 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds java reflection based GWTRunnerProxy implementation. .. Patch Set 1: Actually my reference was Guava, which generates its test methods and they are

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

2013-02-28 Thread mdempsky
LGTM http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails

[gwt-contrib] Change in gwt[master]: Make ConsoleLogHandler use console.error/warn/info.

2013-02-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Make ConsoleLogHandler use console.error/warn/info. .. Patch Set 1: (1 comment) Note: I did not test the change in browsers. I only verified all browsers

[gwt-contrib] Change in gwt[master]: Refactors JVisitor to standarize access to method/field at t...

2013-02-28 Thread Roberto Lublinerman
Roberto Lublinerman has uploaded a new change for review. https://gwt-review.googlesource.com/2070 Change subject: Refactors JVisitor to standarize access to method/field at top of subtree. .. Refactors JVisitor to

[gwt-contrib] Change in gwt[master]: Refactors JVisitor to standarize access to method/field at t...

2013-02-28 Thread Roberto Lublinerman
Roberto Lublinerman has uploaded a new patch set (#4). Change subject: Refactors JVisitor to standarize access to method/field at top of subtree. .. Refactors JVisitor to standarize access to method/field at top of subtree.