[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production

2013-03-16 Thread Daniel Kurka
Daniel Kurka has uploaded a new change for review. https://gwt-review.googlesource.com/2240 Change subject: fixing mismatch in Double.isInfinite between dev / production .. fixing mismatch in Double.isInfinite between

[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production

2013-03-16 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: fixing mismatch in Double.isInfinite between dev / production .. Patch Set 1: Could you add a test to

Re: [gwt-contrib] Re: gwt rebranding

2013-03-16 Thread Thomas Broyer
On Saturday, March 16, 2013 1:28:23 AM UTC+1, James Nelson wrote: Thanks @ Rob for notifying branding experts. The consensus from most of the steering committee is that they like the logo as well, and I for one, pretty much agree. Going way out there on a new logo would lose all built up

[gwt-contrib] Change in gwt[master]: fixing mismatch in Double.isInfinite between dev / production

2013-03-16 Thread Daniel Kurka
Daniel Kurka has abandoned this change. Change subject: fixing mismatch in Double.isInfinite between dev / production .. Abandoned error -- To view, visit https://gwt-review.googlesource.com/2240 To unsubscribe, visit

[gwt-contrib] Re: gwt rebranding

2013-03-16 Thread Jens
https://lh3.googleusercontent.com/-pyhhwBZBseY/UUSdBOkq4tI/AFk/F1BBytRaNSw/s1600/jn_gwt_logo_v1.jpg Just had some time and the above logo is the result ;-) I renamed toolkit to toolbox to get a better association to the box icon. The perspective of the box isn't pixel perfect, but I

Re: [gwt-contrib] Re: gwt rebranding

2013-03-16 Thread Rob Ferguson
Your welcome @ James (although your comment does seem a little disingenuous). And, thank you @ James for helping to build a sense of community. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups

[gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread Daniel Kurka
Hello Everyone, I am a little confused about some issues I encountered on the issue tracker and need some help. This one is about a static field on a JSO: https://code.google.com/p/google-web-toolkit/issues/detail?id=8060 From the docs: Overlay types cannot have instance fields. The fields

Re: [gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread John A. Tamplin
On Sat, Mar 16, 2013 at 3:09 PM, Daniel Kurka kurka.dan...@gmail.comwrote: I am a little confused about some issues I encountered on the issue tracker and need some help. This one is about a static field on a JSO: https://code.google.com/p/google-web-toolkit/issues/detail?id=8060 From the

Re: [gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread Daniel Kurka
Thanks John for clearing this up. This was exactly what I had in mind. I will close the issue AsDesigned, maybe we should document this is little better. -Daniel Am 16.03.2013 um 20:40 schrieb John A. Tamplin j...@jaet.org: On Sat, Mar 16, 2013 at 3:09 PM, Daniel Kurka kurka.dan...@gmail.com

Re: [gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread Colin Alworth
The problem with this answer is that the failure is silent and surprising for Java developers, and that the optimizations can make it even more so. If I recall correctly, calling a static method in the same type from an instance method is not enough to get the static initializer called - an

Re: [gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread John A. Tamplin
On Sat, Mar 16, 2013 at 5:30 PM, Colin Alworth niloc...@gmail.com wrote: The problem with this answer is that the failure is silent and surprising for Java developers, and that the optimizations can make it even more so. If I recall correctly, calling a static method in the same type from an

[gwt-contrib] Error while updating commits in gerrit

2013-03-16 Thread Daniel Kurka
I am having trouble lately with updating commits in gerrit: Anyone else seeing something like this? kurt@kmac:~/Documents/workspace-mgwt/gwt$ git push origin HEAD:refs/changes/2220 Counting objects: 21, done. Delta compression using up to 4 threads. Compressing objects: 100% (9/9), done. Writing

Re: [gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread Daniel Kurka
Am 16.03.2013 um 22:43 schrieb John A. Tamplin j...@jaet.org: On Sat, Mar 16, 2013 at 5:30 PM, Colin Alworth niloc...@gmail.com wrote: The problem with this answer is that the failure is silent and surprising for Java developers, and that the optimizations can make it even more so. If I

[gwt-contrib] Re: Error while updating commits in gerrit

2013-03-16 Thread Daniel Kurka
I should add. This seems to happen to all my recent changes once I try to amend them and update the commit in gerrit. -Daniel Am 16.03.2013 um 22:45 schrieb Daniel Kurka kurka.dan...@gmail.com: I am having trouble lately with updating commits in gerrit: Anyone else seeing something like

Re: [gwt-contrib] Re: gwt rebranding

2013-03-16 Thread Rob Ferguson
- http://brandcrowd.com/logo-design/categories/computer_and_networking/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and

[gwt-contrib] Re: gwt rebranding

2013-03-16 Thread Thomas Broyer
Ah ah, love that new acronym: GWT = Gorgeous Web Toolkit/box ;-) (I prefer toolkit to toolbox, it rhymes with GWiT) On Saturday, March 16, 2013 5:32:02 PM UTC+1, Jens wrote: https://lh3.googleusercontent.com/-pyhhwBZBseY/UUSdBOkq4tI/AFk/F1BBytRaNSw/s1600/jn_gwt_logo_v1.jpg Just had

[gwt-contrib] Re: Error while updating commits in gerrit

2013-03-16 Thread Thomas Broyer
On Saturday, March 16, 2013 10:45:31 PM UTC+1, Daniel Kurka wrote: I am having trouble lately with updating commits in gerrit: Anyone else seeing something like this? kurt@kmac:~/Documents/workspace-mgwt/gwt$ git push origin HEAD:refs/changes/2220 Any reason you're not just pushing

[gwt-contrib] Change in gwt[master]: add Class.getSimpleName to gwt emulation

2013-03-16 Thread Daniel Kurka
Hello John A. Tamplin, Janek Bogucki, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2220 to look at the new patch set (#4). Change subject: add Class.getSimpleName to gwt emulation

[gwt-contrib] Change in gwt[master]: add Class.getSimpleName to gwt emulation

2013-03-16 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: add Class.getSimpleName to gwt emulation .. Patch Set 4: some nit picking @James Lets discuss your suggestions in a new review / issue. -- To view, visit

[gwt-contrib] Change in gwt[master]: add Class.getSimpleName to gwt emulation

2013-03-16 Thread John A. Tamplin
John A. Tamplin has posted comments on this change. Change subject: add Class.getSimpleName to gwt emulation .. Patch Set 4: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2220 To unsubscribe, visit

Re: [gwt-contrib] Error while updating commits in gerrit

2013-03-16 Thread Daniel Kurka
Thanks Thomas, somehow pushing directly to the branch didn`t work on other changes I had opened, but now this seems fine. Am 17.03.2013 um 00:14 schrieb Thomas Broyer t.bro...@gmail.com: On Saturday, March 16, 2013 10:45:31 PM UTC+1, Daniel Kurka wrote: I am having trouble lately with

Re: [gwt-contrib] Static fields on JavaScriptObjects

2013-03-16 Thread Colin Alworth
If you call a method or access a field from pure JS, you aren't going to get the JSO implementation - com.google.gwt.dom.client.Element.removeClassName(String) doesn't exist in the underlying browser, so we build it in Java, and talk to methods/fields which *do* exist in the browser. In other