Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 5:
Matthew: can I go ahead and merge? Any blocker on Google's side?
--
To view, visit
Can someone move that patch over to Gerrit? Would you prefer that I do
it?
(BTW, any reason this hadn't been reviewed yet?)
http://gwt-code-reviews.appspot.com/1839803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed
Jens Nehlmeier has posted comments on this change.
Change subject: Add HasPaths interface.
..
Patch Set 2:
LGTM,
although I don't get why all these feature interfaces like
HasRequestContext, HasEditorErrors and now
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
James Horsley has uploaded a new change for review.
https://gwt-review.googlesource.com/3210
Change subject: Redoing existing svn patch
https://codereview.appspot.com/6132056/ on new git repo to work with gerrit.
..
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Redoing existing svn patch
https://codereview.appspot.com/6132056/ on new git repo to work with gerrit.
..
Patch Set 1:
James could you submit a
James Horsley has posted comments on this change.
Change subject: Redoing existing svn patch
https://codereview.appspot.com/6132056/ on new git repo to work with gerrit.
..
Patch Set 1:
Ick sorry. Will submit a new patch.
James Horsley has uploaded a new change for review.
https://gwt-review.googlesource.com/3186
Change subject: Adds Map support to RequestFactory (see
https://code.google.com/p/google-web-toolkit/issues/detail?id=5524)
..
James Horsley has abandoned this change.
Change subject: Redoing existing svn patch
https://codereview.appspot.com/6132056/ on new git repo to work with gerrit.
..
Abandoned
Contains unintended .orig and .rej files.
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Redoing existing svn patch
https://codereview.appspot.com/6132056/ on new git repo to work with gerrit.
..
Patch Set 1:
Actually you could have
James Horsley has posted comments on this change.
Change subject: Redoing existing svn patch
https://codereview.appspot.com/6132056/ on new git repo to work with gerrit.
..
Patch Set 1:
Will remember for next time. Thanks!
Hi All,
This thread is to continue a conversation in gerrit [1] about trailing
spaces at the end of lines.
GWT convention is not to leave spaces at the end of lines, but some IDEs
add them by default like Eclipse in empty javadoc lines.
Maybe we want to relax this rule, or perhaps we could
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
On 2013/06/04 09:01:51, tbroyer wrote:
Can someone move that patch over to Gerrit? Would you prefer that I do
it?
(BTW, any reason this hadn't been reviewed yet?)
No particular reason other than it dropping off the radar with other
stuff going on. Of course we will want unit tests for this.
Please go ahead and move it, but with a couple of team members away we
probably won't get to it this week.
http://gwt-code-reviews.appspot.com/1839803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google
In Eclipse, I use auto-format on save for edited lines.
If it is a javadoc, it forces you to use correct javadoc tags however for
regular multiine comments if you do some ascii art, then auto-format can
mess it up. In those cases, I simply press Ctrl+Z which just reverts the
last auto-format. It
Hello John A. Tamplin,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3184
to look at the new patch set (#7).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(2 comments)
File
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 7:
(2 comments)
LGTM with a couple of nits.
File
Goktug Gokdogan has posted comments on this change.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Patch Set 2:
(1 comment)
Hello Leeroy Jenkins, Thomas Broyer, Patrick Tucker,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3141
to look at the new patch set (#3).
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Revert Adds onEnsureDebugId delegation to Composite.
..
Revert Adds onEnsureDebugId delegation to Composite.
This reverts commit
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Removes delegation of event from TextBox event handler inside
Goktug Gokdogan has posted comments on this change.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Patch Set 3: Code-Review+2
(Just added a reference to issue after last patch)
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3230
Change subject: Fixes JRawType#getImplementedMethods to return correct
signature for inherited methods
..
Fixes
25 matches
Mail list logo
