Revision: 9165
Author: jbrosenb...@google.com
Date: Fri Oct 29 06:15:35 2010
Log: Cleanup for EnumsTest and EnumsWithNameObfuscationTest suites, make sure they always run with correct configuration property

Review at http://gwt-code-reviews.appspot.com/1018801

Review by: cromwell...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9165

Added:
 /trunk/user/test/com/google/gwt/dev/jjs/EnumsSuite.gwt.xml
Deleted:
 /trunk/user/test/com/google/gwt/dev/jjs/EnumsWithNameObfuscationSuite.java
Modified:
/trunk/user/test/com/google/gwt/dev/jjs/EnumsWithNameObfuscationSuite.gwt.xml
 /trunk/user/test/com/google/gwt/dev/jjs/test/EnumsTest.java
/trunk/user/test/com/google/gwt/dev/jjs/test/EnumsWithNameObfuscationTest.java

=======================================
--- /dev/null
+++ /trunk/user/test/com/google/gwt/dev/jjs/EnumsSuite.gwt.xml Fri Oct 29 06:15:35 2010
@@ -0,0 +1,20 @@
+<!-- --> +<!-- Copyright 2010 Google Inc. --> +<!-- Licensed under the Apache License, Version 2.0 (the "License"); you --> +<!-- may not use this file except in compliance with the License. You may --> +<!-- may obtain a copy of the License at --> +<!-- --> +<!-- http://www.apache.org/licenses/LICENSE-2.0 --> +<!-- --> +<!-- Unless required by applicable law or agreed to in writing, software --> +<!-- distributed under the License is distributed on an "AS IS" BASIS, --> +<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or --> +<!-- implied. License for the specific language governing permissions and --> +<!-- limitations under the License. -->
+
+<module>
+  <inherits name="com.google.gwt.dev.jjs.CompilerSuite"/>
+
+  <set-configuration-property name="compiler.enum.obfuscate.names"
+        value="false" />
+</module>
=======================================
--- /trunk/user/test/com/google/gwt/dev/jjs/EnumsWithNameObfuscationSuite.java Fri Sep 10 06:27:47 2010
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not - * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.google.gwt.dev.jjs;
-
-import com.google.gwt.dev.jjs.test.EnumsWithNameObfuscationTest;
-import com.google.gwt.junit.tools.GWTTestSuite;
-
-import junit.framework.Test;
-
-/**
- * The complete compiler suite.
- */
-public class EnumsWithNameObfuscationSuite {
-
-  public static Test suite() {
-    GWTTestSuite suite = new GWTTestSuite(
-        "Test for com.google.gwt.dev.jjs (with enum name obfuscation)");
-
-    // $JUnit-BEGIN$
-    suite.addTestSuite(EnumsWithNameObfuscationTest.class);
-    // $JUnit-END$
-
-    return suite;
-  }
-
-}
=======================================
--- /trunk/user/test/com/google/gwt/dev/jjs/EnumsWithNameObfuscationSuite.gwt.xml Fri Sep 10 06:27:47 2010 +++ /trunk/user/test/com/google/gwt/dev/jjs/EnumsWithNameObfuscationSuite.gwt.xml Fri Oct 29 06:15:35 2010
@@ -15,5 +15,6 @@
 <module>
   <inherits name="com.google.gwt.dev.jjs.CompilerSuite"/>

- <set-configuration-property name="compiler.enum.obfuscate.names" value="true" />
+  <set-configuration-property name="compiler.enum.obfuscate.names"
+        value="true" />
 </module>
=======================================
--- /trunk/user/test/com/google/gwt/dev/jjs/test/EnumsTest.java Mon Oct 18 12:52:42 2010 +++ /trunk/user/test/com/google/gwt/dev/jjs/test/EnumsTest.java Fri Oct 29 06:15:35 2010
@@ -84,7 +84,7 @@
   }

   public String getModuleName() {
-    return "com.google.gwt.dev.jjs.CompilerSuite";
+    return "com.google.gwt.dev.jjs.EnumsSuite";
   }

   public void testCompareTo() {
@@ -190,6 +190,7 @@
     }
   }

+  @SuppressWarnings("unchecked")
   public void testValueOf() {
     assertEquals(Basic.A, Basic.valueOf("A"));
     assertEquals(Basic.B, Basic.valueOf("B"));
=======================================
--- /trunk/user/test/com/google/gwt/dev/jjs/test/EnumsWithNameObfuscationTest.java Mon Oct 18 12:52:42 2010 +++ /trunk/user/test/com/google/gwt/dev/jjs/test/EnumsWithNameObfuscationTest.java Fri Oct 29 06:15:35 2010
@@ -127,6 +127,7 @@
   }

   @Override
+  @SuppressWarnings("unchecked")
   public void testValueOf() {

     try {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to