Brian Slesinsky has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 8:
Had to roll this back again due to projects that implement the
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2110
to look at the new patch set (#8).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
Thomas Broyer has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 8: Code-Review+2
Patch-set 8 is only a rebase of patch-set 7 that
Thomas Broyer has submitted this change and it was merged.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Adds isStandalone to ImageResource so Image can used an UnclippedState.
Thomas Broyer has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 5:
(2 comments)
Hello Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2110
to look at the new patch set (#6).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
Hello Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a rebased change. Please visit
https://gwt-review.googlesource.com/2110
to look at the new rebased patch set (#7).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
Matthew Dempsky has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 7: Verified+1 Code-Review+1
LGTM, tests all pass now. Goktug, I'll
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 7: Code-Review+2
--
To view, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 5:
(2 comments)
I hate gerrit when Add comment doesn't publish the
Hello Matthew Dempsky, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2110
to look at the new patch set (#4).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
Thomas Broyer has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3:
(2 comments)
* Fixed ImageResourceCellTest by using
Hello Matthew Dempsky, Goktug Gokdogan,
I'd like you to reexamine a rebased change. Please visit
https://gwt-review.googlesource.com/2110
to look at the new rebased patch set (#5).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 5:
(2 comments)
Matthew Dempsky has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3:
(2 comments)
Seems okay to me, though if tests are failing we
Matthew Dempsky has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3:
FYI, the test failures are:
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3: Verified-1 -Code-Review
UiBinderTest (only with htmlunit),
Matthew Dempsky has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3: Verified+1
Woot, this patch set PASSED the build and checkstyle
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 3: Code-Review+1
Thanks. Internally, we need to run corresponding
Thomas Broyer has uploaded a new patch set (#2).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Adds isStandalone to ImageResource so Image can used an UnclippedState.
Thomas Broyer has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 1:
(5 comments)
Also made repeatStyle=Both be isStandalone=true.
Thomas Broyer has uploaded a new patch set (#3).
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Adds isStandalone to ImageResource so Image can used an UnclippedState.
Thomas Broyer has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 1:
(1 comment)
Goktug Gokdogan has posted comments on this change.
Change subject: Adds isStandalone to ImageResource so Image can used an
UnclippedState.
..
Patch Set 1:
(5 comments)
24 matches
Mail list logo