Thomas Broyer has submitted this change and it was merged.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Make Element.hasTagName(...) case-insensitive.
Helpful because the various Element TAG constants are
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 7:
Hoorays!
--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https:
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 7: Code-Review+2
@Matthew: any idea why Jenkins doesn't pick it up?
--
To view, visit https://gwt-r
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 6: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe,
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 6: Code-Review+2
Grrr, Jenkins really doesn't want to pick it up to give its Verified+1.
--
To view
Hello Manuel Carrasco Moñino, Daniel Kurka, Goktug Gokdogan,
I'd like you to reexamine a rebased change. Please visit
https://gwt-review.googlesource.com/2975
to look at the new rebased patch set (#6).
Change subject: Make Element.hasTagName(...) case-insensitive.
Daniel Kurka has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 5: Code-Review+2
LGTM
You can submit this change now using the publish & submit button
--
To view,
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 5: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit ht
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 5: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe,
Daniel Kurka has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 4: Code-Review+1
LGTM, please address Manuel's comment
--
To view, visit https://gwt-review.googleso
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 4: Code-Review+1
(1 comment)
File use
Goktug Gokdogan has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 3: Code-Review+1
Opps, Thomas has some comments. I'll revert to +1 and let him to do +2.
--
To vi
Goktug Gokdogan has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 1:
Do you think we could add a test for that? (in ElementTest; something like
createDivElement() a
14 matches
Mail list logo