Re: [gwt-contrib] Last call for GWT 2.6.1

2014-04-07 Thread Goktug Gokdogan
It looks quite safe with the tests in place and didn't break anything internally. On the other hand, this is not a regression nor a bug so Thomas and you should decide if you would like to open the door for such patches in this release :) On Mon, Apr 7, 2014 at 11:38 AM, Daniel Kurka wrote: > I

Re: [gwt-contrib] Last call for GWT 2.6.1

2014-04-07 Thread Daniel Kurka
I am really not sure if we want to include any other changes than easy bugfixes here. @goktug since you reviewed the change what do you think about possible breakages? On Mon, Apr 7, 2014 at 5:49 PM, Stephen Haberman wrote: > Hi Daniel, > > > If you want to get your changes into GWT 2.6.1, t

Re: [gwt-contrib] Last call for GWT 2.6.1

2014-04-07 Thread Stephen Haberman
Hi Daniel, > If you want to get your changes into GWT 2.6.1, they need to get in > before Friday. Selfishly, our app is depending on this patch now: https://gwt-review.googlesource.com/#/c/6780/ I know it's not a bug fix, but it's pretty simple; I assume it's find to cherry pick into 2.6.1? I c

[gwt-contrib] Last call for GWT 2.6.1

2014-04-07 Thread Daniel Kurka
As a reminder, we are going to start building GWT 2.6.1 from the GWT 2.6 release branch (https://gwt-review.googlesource.com/#/q/status:open+project:gwt+branch:release/2.6) this Friday (11th April). If you want to get your changes into GWT 2.6.1, they need to get in before Friday. There's stil