Reviewers: zundel,

Description:
Notify DesignTimeUtils about all beans, not only about UIObjects.


Please review this at http://gwt-code-reviews.appspot.com/1483801/

Affected files:
  M user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/UIObjectParser.java


Index: user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java
===================================================================
--- user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java (revision 10452) +++ user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java (working copy)
@@ -55,6 +55,9 @@
    */
   public void parse(XMLElement elem, String fieldName, JClassType type,
       UiBinderWriter writer) throws UnableToCompleteException {
+
+    writer.getDesignTime().handleUIObject(writer, elem, fieldName);
+
     final Map<String, String> setterValues = new HashMap<String, String>();
final Map<String, String> localizedValues = fetchLocalizedAttributeValues(
         elem, writer);
Index: user/src/com/google/gwt/uibinder/elementparsers/UIObjectParser.java
===================================================================
--- user/src/com/google/gwt/uibinder/elementparsers/UIObjectParser.java (revision 10452) +++ user/src/com/google/gwt/uibinder/elementparsers/UIObjectParser.java (working copy)
@@ -29,9 +29,6 @@

   public void parse(XMLElement elem, String fieldName, JClassType type,
       UiBinderWriter writer) throws UnableToCompleteException {
-
-    writer.getDesignTime().handleUIObject(writer, elem, fieldName);
-
     String debugId = elem.consumeStringAttribute("debugId", null);
     if (null != debugId) {
       writer.addStatement("%s.ensureDebugId(%s);", fieldName, debugId);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to