Re: [gwt-contrib] Patch for RichTextEditor

2012-10-12 Thread Stephen Haberman
It looks like he posted a complete patch almost three years ago. What do we need to do to get this into trunk? https://developers.google.com/web-toolkit/makinggwtbetter#contributingcode Generally, sign a CLA, and upload it to Rietveld; not sure who to pick as the reviewer, I'll volunteer

Re: [gwt-contrib] Patch for RichTextEditor

2012-10-05 Thread Casey
It looks like he posted a complete patch almost three years ago. What do we need to do to get this into trunk? http://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=formatBlockcolspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=4554 On

Re: [gwt-contrib] Patch for RichTextEditor

2010-02-10 Thread Joel Webber
Sebastian, Sorry it's taken so long for anyone to respond. This sounds like useful functionality, and I would suggest creating an issue ( http://code.google.com/p/google-web-toolkit/issues/) and a patch for public discussion (http://gwt-code-reviews.appspot.com/). That way it will be easier for

[gwt-contrib] Patch for RichTextEditor

2010-01-22 Thread Sebastian
Hello, I was missing the ability to format a block with h1 - h6 tags. I researched the topic and build a patch which allows to insert block tags. It makes use of the FormatBlock command. I would like to ask, if you are interested in the patch and discuss the coding decision I took. 1) I