Reviewers: amitmanjhi, Message: I imagine I'm not the only one who tweaks JUnitShell.TEST_METHOD_TIMEOUT_MILLIS when in the middle of long debug sessions. Wouldn't it be nice to be able to do so without touching the code?
General questions: is a system property the right way to do this; is the property name okay; and is it okay to hit the system properties at class init time like that? Also deletes unneeded @SuppressWarnings Please review this at http://gwt-code-reviews.appspot.com/89819 Affected files: M user/src/com/google/gwt/junit/JUnitShell.java Index: user/src/com/google/gwt/junit/JUnitShell.java diff --git a/user/src/com/google/gwt/junit/JUnitShell.java b/user/src/com/google/gwt/junit/JUnitShell.java index 3c61a6b4f1ae0d38a6fad75bdd1f120a9806f3f5..5b04f7394a4a4fef1b78d0b73ec9e7bb5252f88b 100644 --- a/user/src/com/google/gwt/junit/JUnitShell.java +++ b/user/src/com/google/gwt/junit/JUnitShell.java @@ -99,7 +99,6 @@ public class JUnitShell extends GWTShell { void processResult(TestCase testCase, JUnitResult result); } - @SuppressWarnings("deprecation") class ArgProcessor extends GWTShell.ArgProcessor { public ArgProcessor() { @@ -350,7 +349,8 @@ public class JUnitShell extends GWTShell { * method, in milliseconds, measured from when the <i>last</i> client connects * (and thus starts the test). default of 5 minutes. */ - private static final long TEST_METHOD_TIMEOUT_MILLIS = 5 * 60 * 1000; + private static final long TEST_METHOD_TIMEOUT_MILLIS = + Integer.getInteger("gwt.testTimeoutMinutes", 5) * 60 * 1000; /** * Singleton object for hosting unit tests. All test case instances executed --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To post to this group, send email to google-web-toolkit-contributors@googlegroups.com To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/google-web-toolkit-contributors?hl=en -~----------~----~----~----~------~----~------~--~---
