Re: [gwt-contrib] RR: allow CheckBox to accept null?

2010-08-26 Thread Johan Rydberg
On 8/25/10 6:16 PM, Ray Ryan wrote: The use case is dealing with boolean values that may be null, and really a check box is just the wrong UI there. Withdrawn. I know of at least one data binding framework, gwt-pectin, that signals no value using null. As a work-around gwt-pectin has it's own

Re: [gwt-contrib] RR: allow CheckBox to accept null?

2010-08-26 Thread Bruce Johnson
Fwiw, I don't actually care. It just seemed like something that needed some devil's advocacy. On Thursday, August 26, 2010, Ray Ryan rj...@google.com wrote: Andrew, how would this be?     CheckBox cb = new CheckBox();     cb.setValue(null);     assertFalse(cb.getValue()); rjrjr On Thu,

Re: [gwt-contrib] RR: allow CheckBox to accept null?

2010-08-25 Thread Bruce Johnson
Can you provide a little more context for why it should work this way? On Tue, Aug 24, 2010 at 6:49 PM, Ray Ryan rj...@google.com wrote: When we made the CheckBox widget implement HasValue, we had it throw an illegal argument exception when setValue() is called with null. I think we goofed.

Re: [gwt-contrib] RR: allow CheckBox to accept null?

2010-08-25 Thread Ray Ryan
Yeah, thinking about it by the light of day I think it's the wrong direction. The use case is dealing with boolean values that may be null, and really a check box is just the wrong UI there. Withdrawn. On Wed, Aug 25, 2010 at 7:01 AM, Bruce Johnson br...@google.com wrote: Can you provide a

Re: [gwt-contrib] RR: allow CheckBox to accept null?

2010-08-25 Thread Bruce Johnson
Glad I looked at it funny, then. Micro-design reviews ftw. On Wed, Aug 25, 2010 at 12:16 PM, Ray Ryan rj...@google.com wrote: Yeah, thinking about it by the light of day I think it's the wrong direction. The use case is dealing with boolean values that may be null, and really a check box

[gwt-contrib] RR: allow CheckBox to accept null?

2010-08-24 Thread Ray Ryan
When we made the CheckBox widget implement HasValue, we had it throw an illegal argument exception when setValue() is called with null. I think we goofed. Can we get away with relaxing that? I'd like this to be the case: CheckBox cb = new CheckBox(); cb.setValue(null);