[gwt-contrib] Re: Add names to test targets so we know which ones failed

2009-11-04 Thread John LaBanca
ping Thanks, John LaBanca jlaba...@google.com On Tue, Nov 3, 2009 at 4:22 PM, John LaBanca jlaba...@google.com wrote: +fabbott Used the wrong screen name. Thanks, John LaBanca jlaba...@google.com On Tue, Nov 3, 2009 at 4:21 PM, jlaba...@google.com wrote: Reviewers:

[gwt-contrib] Re: Add names to test targets so we know which ones failed

2009-11-04 Thread fabbott
LGTM, with one whitespace nit. Pity ant doesn't have a built-in $ant.target property, though. http://gwt-code-reviews.appspot.com/91810/diff/1/3 File user/build.xml (right): http://gwt-code-reviews.appspot.com/91810/diff/1/3#newcode380 Line 380: test.cases=test.dev.htmlunit.tests I don't

[gwt-contrib] Re: Add names to test targets so we know which ones failed

2009-11-04 Thread jlabanca
committed as r6646 with whitespace fix. http://gwt-code-reviews.appspot.com/91810 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Add names to test targets so we know which ones failed

2009-11-03 Thread John LaBanca
+fabbott Used the wrong screen name. Thanks, John LaBanca jlaba...@google.com On Tue, Nov 3, 2009 at 4:21 PM, jlaba...@google.com wrote: Reviewers: freeland_google.com, Description: Description: Since we run tests in parallel, its really difficult to tell which test target