Hey Shanjian :) The patch mostly looks good, but running it, I got a failure in test_predefinedFormat. This smells like a test that might only pass if you're on the west coast; the result was off by three hours.
(here's the trace) junit.framework.AssertionFailedError: expected=1:49:24 PM America/Los_Angeles actual=10:49:24 AM America/Los_Angeles at junit.framework.Assert.fail(Assert.java:181) at junit.framework.Assert.assertEquals(Assert.java:107) at junit.framework.Assert.assertEquals(Assert.java:51) at com.google.gwt.i18n.client.DateTimeFormat_en_Test.test_predefinedFormat(DateTimeFormat_en_Test.java:79) ... Could you take a look at that? Thanks! On Wed, Nov 19, 2008 at 5:58 PM, Shanjian Li <[EMAIL PROTECTED]> wrote: > This patch added a unit test for DateTimeFormat class. I want to use > this unit test to give some example about how to use time zone support > in DateTimeFormat. It will also be valuable for further time zone > enhancement. > > shanjian > > > > -- Alex Rudnick swe, gwt, atl --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---