r8387
On Wed, Jul 14, 2010 at 12:32 PM, rj...@google.com wrote:
Looks good, will submit
On 2010/07/12 20:14:38, markovuksanovic wrote:
Some error checking changes...
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reverted, breaks Grid subclasses. Oops, working on the fix.
On Fri, Jul 16, 2010 at 2:42 PM, Ray Ryan rj...@google.com wrote:
r8387
On Wed, Jul 14, 2010 at 12:32 PM, rj...@google.com wrote:
Looks good, will submit
On 2010/07/12 20:14:38, markovuksanovic wrote:
Some error checking
Nice. Just some error checking nits left.
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode86
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:86:
Did the changes... Will post the patch a little later... I need to
convert it from git to svn format first...
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
ping...
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Changed the way in which uibinder xml file is parsed.
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I just found one small typo - but I won't commit a new patch now just in
case something else needs to be fixed as well.
@rjrjr: If everything else is ok, I'll commit an updated patch.
http://gwt-code-reviews.appspot.com/154810/diff/63002/70003
File
I just found one small typo - but I won't commit a new patch now just in
case something else needs to be fixed as well.
@rjrjr: If everything else is ok, I'll commit an updated patch.
http://gwt-code-reviews.appspot.com/154810/diff/63002/70003
File
Remember this? It's really close, I think just one more change is needed
(below).
http://gwt-code-reviews.appspot.com/154810/diff/22003/54004
File
user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java
(right):
Yeah, I do remember. I will make the change later today.
On 2010/07/02 14:40:57, Ray Ryan wrote:
Remember this? It's really close, I think just one more change is
needed
(below).
http://gwt-code-reviews.appspot.com/154810/diff/22003/54004
File
Ok, I had a look and just remembered why I used more calls to resize
methods.
The GridParser walks through the Grid and on the fly calculates the
size. So if it comes to an element that doesn't fit into the current
grid element it expands it (either by number of columns, or rows -
depends which
You're trading off compile time simplicity at the expense of runtime
efficiency, and it's a bad trade.
Rather than emitting java lines as you walk the XML, you can build a model
of what you want to write. Once you're done with your traversal, you can
write out a single call to resize(int, int),
Thanks for your patience, Marko, and sorry to be so inconsiderate of
your time.
http://gwt-code-reviews.appspot.com/154810/diff/1001/1002
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/154810/diff/1001/1002#newcode37
One other note: your patch is very likely to land after
http://gwt-code-reviews.appspot.com/241801, and may need to be tweaked.
Take a look at the element parser changes there to get a feel for it.
http://gwt-code-reviews.appspot.com/154810/show
--
One more question - how to know which person to invite for a code
review?
On Mar 7, 11:11 am, Marko Vuksanovic markovuksano...@gmail.com
wrote:
I have created a patch that enables user to create Grid and its child
elements using UiBinder (issue 4705
You don't, really. I'm the right person in this case, and you're right near
the top of my todo list. Sorry I haven't gotten to it yet.
On Mon, Mar 8, 2010 at 3:46 PM, Marko Vuksanovic
markovuksano...@gmail.comwrote:
One more question - how to know which person to invite for a code
review?
On
17 matches
Mail list logo
