[gwt-contrib] Re: Add support for soft permutations to SingleScriptLinker. (issue1678803)

2012-04-08 Thread jat
LGTM It seems like there should be some test for this to make sure it keeps working. Could you extend SingleScriptLinkerTest to make sure that it handles collapsing soft permutations? http://gwt-code-reviews.appspot.com/1678803/ --

[gwt-contrib] Re: Add support for soft permutations to SingleScriptLinker. (issue1678803)

2012-04-08 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1678803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add support for soft permutations to SingleScriptLinker. (issue1678803)

2012-04-05 Thread John Tamplin
On Thu, Apr 5, 2012 at 5:01 PM, mdemp...@google.com wrote: On 2012/04/05 20:44:10, jat wrote: It seems like there should be some test for this to make sure it keeps working. Could you extend SingleScriptLinkerTest to make sure that it handles collapsing soft permutations? Sure. Can