LGTM

On Wed, Jun 16, 2010 at 10:57 AM, <amitman...@google.com> wrote:

> Reviewers: Ray Ryan,
>
> Description:
> Added a warning to the javadoc of each src file and to package.html in
> the app, requestfactory, and valuestore modules.
>
> Review by: rj...@google.com
>
> Please review this at http://gwt-code-reviews.appspot.com/625801/show
>
> Affected files:
>  M bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java
>  M bikeshed/src/com/google/gwt/app/client/EditorSupport.java
>  M bikeshed/src/com/google/gwt/app/client/NotificationMole.java
>  M bikeshed/src/com/google/gwt/app/client/package.html
>  M bikeshed/src/com/google/gwt/app/package.html
>  M bikeshed/src/com/google/gwt/app/place/AbstractActivity.java
>  M bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
>  M bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java
>  M bikeshed/src/com/google/gwt/app/place/Activity.java
>  M bikeshed/src/com/google/gwt/app/place/ActivityManager.java
>  M bikeshed/src/com/google/gwt/app/place/ActivityMapper.java
>  M bikeshed/src/com/google/gwt/app/place/Place.java
>  M bikeshed/src/com/google/gwt/app/place/PlaceChangeEvent.java
>  M bikeshed/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java
>  M bikeshed/src/com/google/gwt/app/place/PlaceController.java
>  M bikeshed/src/com/google/gwt/app/place/PlacePicker.java
>  M bikeshed/src/com/google/gwt/app/place/PlacePickerView.java
>  M bikeshed/src/com/google/gwt/app/place/package.html
>  M bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java
>  M bikeshed/src/com/google/gwt/app/rebind/package.html
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/ClientRequestHelper.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java
>  M bikeshed/src/com/google/gwt/requestfactory/server/package.html
>  M bikeshed/src/com/google/gwt/requestfactory/shared/Id.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/Receiver.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/RecordListRequest.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/RecordRequest.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/RequestEvent.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/ServerOperation.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/ServerType.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/SyncRequest.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/Version.java
>  M
> bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java
>  M bikeshed/src/com/google/gwt/requestfactory/shared/package.html
>  M
> bikeshed/src/com/google/gwt/valuestore/client/DeltaValueStoreJsonImpl.java
>  M bikeshed/src/com/google/gwt/valuestore/client/RecordKey.java
>  M bikeshed/src/com/google/gwt/valuestore/client/SyncResultImpl.java
>  M bikeshed/src/com/google/gwt/valuestore/client/ValueStoreJsonImpl.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/DeltaValueStore.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/Property.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/PropertyReference.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/Record.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/RecordChangedEvent.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/SyncResult.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/Value.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/ValueStore.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/WriteOperation.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordImpl.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordSchema.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordToTypeMap.java
>  M bikeshed/src/com/google/gwt/valuestore/shared/package.html
>  M bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java
>  M bikeshed/src/com/google/gwt/valuestore/ui/PropertyColumn.java
>  M bikeshed/src/com/google/gwt/valuestore/ui/PropertyView.java
>  M bikeshed/src/com/google/gwt/valuestore/ui/RecordDetailsView.java
>  M bikeshed/src/com/google/gwt/valuestore/ui/RecordEditView.java
>  M bikeshed/src/com/google/gwt/valuestore/ui/RecordListView.java
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to