[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-07 Thread zundel
http://gwt-code-reviews.appspot.com/1254801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-07 Thread zundel
http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001#newcode792 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:792: * Note: OpenJDK

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-06 Thread Eric Ayers
This change removes the redundant copy of source in TypeOracleMediatorTestBase.java (except for the mocks of a few system classes) On Thu, Jan 6, 2011 at 2:00 PM, zun...@google.com wrote: http://gwt-code-reviews.appspot.com/1254801/show -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-06 Thread tobyr
Overall LGTM with a few changes. http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001#newcode792

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread zundel
This change adds a unit test for the TypeOracleMediator that feeds byte code instead of source. http://gwt-code-reviews.appspot.com/1254801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread zundel
http://gwt-code-reviews.appspot.com/1254801/diff/1/5 File dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java (right): http://gwt-code-reviews.appspot.com/1254801/diff/1/5#newcode1391 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:1391: //

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread jbrosenberg
LGTM (with 1 minor nit about a comment) http://gwt-code-reviews.appspot.com/1254801/diff/1/3 File dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorFromByteCodeTest.java (right): http://gwt-code-reviews.appspot.com/1254801/diff/1/3#newcode31

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread scottb
LGTM, I think. I assume all the new units are being moved from code snippets embedded in exist test code? Diff on TypeOracleMediatorTestBase difficult to eyeball. http://gwt-code-reviews.appspot.com/1254801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread zundel
http://gwt-code-reviews.appspot.com/1254801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread zundel
On 2011/01/05 18:59:02, scottb wrote: LGTM, I think. What is that supposed to mean?!? I updated a few comments in the mediatortest/ files in the patch. I assume all the new units are being moved from code snippets embedded in exist test code? More or less. The only difference I remember

[gwt-contrib] Re: Adds a unit test for the TypeOracleMediator that feeds byte code instead of source. (issue1254801)

2011-01-05 Thread Scott Blum
On Wed, Jan 5, 2011 at 2:13 PM, zun...@google.com wrote: On 2011/01/05 18:59:02, scottb wrote: LGTM, I think. What is that supposed to mean?!? Sorry, it means I didn't scrutinize this to the Nth degree, just looked over it at a high level. I assume all the new units are being moved