Re: [gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-27 Thread Grzegorz Kossakowski
Thanks for reply. This is in line with my schedule. I'll be watching your progress with great interest. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread zundel
I see what you did with the accessibility but not why. Can you illuminate us? http://gwt-code-reviews.appspot.com/1304802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread scottb
Oh right, sorry! This is so you can build a partial AST without a JProgram, the main change I'm still working on. http://gwt-code-reviews.appspot.com/1304802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread jbrosenberg
LGTM http://gwt-code-reviews.appspot.com/1304802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread Grzegorz Kossakowski
It looks like you are working on something that might be interesting to me. Is there any place I can find more information on this change? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread Scott Blum
I don't have anything great written up, but here's the gist of it: Currently, when you do a web mode compile, JDT actually runs twice. First, it runs from CompilationStateBuilder and compiles all the source code in your project. The output of this is used to build TypeOracle, which is a

Re: [gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread Grzegorz Kossakowski
Thanks Scott for this. It's enough for me to understand motivation and (at least some) implications of this change. This is something which is certainly within my interest. Actually, what you described is exactly what I wanted to see for a long time. I parse jribble nodes twice for exactly the

Re: [gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-26 Thread Scott Blum
No hard commitments, but I'm looking on the order of a month or thereabout. On Wed, Jan 26, 2011 at 3:25 PM, Grzegorz Kossakowski grzegorz.kossakow...@gmail.com wrote: Thanks Scott for this. It's enough for me to understand motivation and (at least some) implications of this change. This is