I opened issue #3409 for the Suggestion change and issue #3410 for the
HasValue change.
http://code.google.com/p/google-web-toolkit/issues/detail?id=3409
http://code.google.com/p/google-web-toolkit/issues/detail?id=3410
- Isaac
On Wed, Feb 25, 2009 at 9:07 AM, Arthur Kalmenson
On a side note, I found when I was writing this patch that HasValue
extends HasValueChangeHandlers in trunk. It occurs to me that this
relationship could possibly be backwards. I don't think that something
with a value necessarily should be required to broadcast changes. See
the
I like the super class. I'm not sure it actually needs to be abstract.
I think that by adding HasValueT to Suggestion we can do it with
concrete classes.
TypedSuggestBoxT (SuggestBoxBase?)
SuggestionT implements HasValueT
SuggestOracleT
SuggestBox extends TypedSuggestBoxString
It could work, though I found when I used this technique with
DatePicker (DatePicker extends AbstractDatePickerMonthSelector,
CalandarView), there was some feedback that having that abstract type layer
was slightly confusing because good OO practice implied that references
should then be typed as
On Tue, Feb 24, 2009 at 10:44 AM, Emily Crutcher e...@google.com wrote:
It could work, though I found when I used this technique with
DatePicker (DatePicker extends AbstractDatePickerMonthSelector,
CalandarView), there was some feedback that having that abstract type layer
was slightly
That feedback sounds a bit pedantic and impractical to me. And my job title
used to be Senior Pedant.
On Tue, Feb 24, 2009 at 7:44 AM, Emily Crutcher e...@google.com wrote:
It could work, though I found when I used this technique with
DatePicker (DatePicker extends
HasValueT extends Suggestion sounds wrong to me. The suggestions are not
the value that we're getting from the user, they're prompts to the user to
help her get to the actual value. I'd much more expect a SuggestionBox to be
HasValueString -- it's just a TextBox that happens to have chats with the
+1 to that comment. BTW, I didn't realize your title *actually* used to be
Senior Pedant. That's even better than my old friend Charlie, whose title
was Senior Bit Twiddler (he was a CompE after all...)!
On Tue, Feb 24, 2009 at 10:56 AM, Ray Ryan rj...@google.com wrote:
HasValueT extends
HasValueT extends Suggestion sounds wrong to me.
I agree. SuggestBox implements HasValueT extends Suggestion was not
actually what I was proposing, and I apologize if it appeared that
way. T would be the type of the DAO, the logical value represented by
the suggestion. My intent is that the
How about extracting a parameterized super class:
AbstractSuggestionBoxT extends Suggestion
SuggestionBox extends AbstractSuggestionBoxSuggestion
rjrjr
On Mon, Feb 23, 2009 at 7:15 PM, Emily Crutcher e...@google.com wrote:
On Mon, Feb 23, 2009 at 7:04 PM, Isaac Truett itru...@gmail.com
If that concern doesn't seem like it would be a problem, then I definitely
agree with you that creating abstract base classes that have the
parametrized types seems like the best solution.
On Tue, Feb 24, 2009 at 10:54 AM, Ray Ryan rj...@google.com wrote:
That feedback sounds a bit pedantic
On Mon, Feb 23, 2009 at 7:04 PM, Isaac Truett itru...@gmail.com wrote:
The API documentation has this to say on the subject:
[...] To send back a DTO with each suggestion, extend the Suggestion
interface and define a getter method that has a return value of the
DTO's type. Define a class
12 matches
Mail list logo
