On 2012/01/23 23:43:12, rdayal wrote:
LGTM.
Submitted.
http://gwt-code-reviews.appspot.com/1588803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
http://gwt-code-reviews.appspot.com/1588803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1588803/diff/11001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
File src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right):
Thanks for doing this!
A few comments.
http://gwt-code-reviews.appspot.com/1588803/diff/2001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
File src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right):
Given that only UTF-8 is used, how about an eagerly-initialized
RPCServletUtil.UTF8_CHARSET instead? (similar to Guava's Charsets.UTF_8
[1])
[1]
http://docs.guava-libraries.googlecode.com/git-history/v10.0.1/javadoc/com/google/common/base/Charsets.html#UTF_8
LGTM, but I'm not a Googler sorry. You'll have to find a reviewer and
committer.
http://gwt-code-reviews.appspot.com/1588803/diff/2001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
File src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right):
