http://gwt-code-reviews.appspot.com/1230801/diff/1/3
File samples/validation/ValidationMesssges-i18n (right):
http://gwt-code-reviews.appspot.com/1230801/diff/1/3#newcode1
samples/validation/ValidationMesssges-i18n:1: #!/bin/sh
I think this file does not need to be committed.
http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047
File
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
(right):
http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047#newcode118
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java:118:
}
http://gwt-code-reviews.appspot.com/1230801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Patch set 1 contains a number of unreplied comments.
On 2010/12/20 20:41:11, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1230801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I see where I missed those. Working on them now.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1230801/diff/1/3
File samples/validation/ValidationMesssges-i18n (right):
http://gwt-code-reviews.appspot.com/1230801/diff/1/3#newcode1
samples/validation/ValidationMesssges-i18n:1: #!/bin/sh
On 2010/12/20 19:10:53, rchandia wrote:
I think this file does not
http://gwt-code-reviews.appspot.com/1230801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2010/12/20 22:10:00, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1230801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1230801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors