[gwt-contrib] Re: Change Date to use JSO field rather than expando, add null checks

2009-05-30 Thread John Tamplin
On Fri, May 29, 2009 at 6:10 PM, amitman...@google.com wrote: Besides Scott's suggestion, I have one more thing to add. For any method that mutates the Date, wouldn't it be more useful to call th...@java.util.date::checkJsDate()(); both when entering and exiting the method? Then, we can get a

[gwt-contrib] Re: Change Date to use JSO field rather than expando, add null checks

2009-05-29 Thread amitmanjhi
Hi John, Besides Scott's suggestion, I have one more thing to add. For any method that mutates the Date, wouldn't it be more useful to call th...@java.util.date::checkJsDate()(); both when entering and exiting the method? Then, we can get a stack trace of the problem code immediately. After

[gwt-contrib] Re: Change Date to use JSO field rather than expando, add null checks

2009-05-27 Thread scottb
http://gwt-code-reviews.appspot.com/33831/diff/1/2 File user/super/com/google/gwt/emul/java/util/Date.java (right): http://gwt-code-reviews.appspot.com/33831/diff/1/2#newcode169 Line 169: @java.util.Date::checkJsDate()(); Should be th...@java.util.date:: and so on throughout.