[gwt-contrib] Re: Change the way modules are mapped to tabs in the Swing UI

2009-08-19 Thread jat
Thanks for the review. http://gwt-code-reviews.appspot.com/59801/diff/2001/2011 File dev/oophm/src/com/google/gwt/dev/ModuleTabPanel.java (right): http://gwt-code-reviews.appspot.com/59801/diff/2001/2011#newcode89 Line 89: public synchronized void addModule(String moduleName, On 2009/08/20

[gwt-contrib] Re: Change the way modules are mapped to tabs in the Swing UI

2009-08-19 Thread Ray Ryan
On Wed, Aug 19, 2009 at 8:29 PM, j...@google.com wrote: Thanks for the review. http://gwt-code-reviews.appspot.com/59801/diff/2001/2011 File dev/oophm/src/com/google/gwt/dev/ModuleTabPanel.java (right): http://gwt-code-reviews.appspot.com/59801/diff/2001/2011#newcode89 Line 89: public

[gwt-contrib] Re: Change the way modules are mapped to tabs in the Swing UI

2009-08-17 Thread jat
Forgot to mention -- you will need plugins built from http://gwt-code-reviews.appspot.com/51834/show to get the session/URL feature. Which reminds me, are we going to support pre-MS1 plugins? If so, I need to make sure it behaves reasonably if the extra information isn't available.