[gwt-contrib] Re: Changes served location of UiBinder's xhtml.ent from svn to downloads

2009-09-25 Thread Ray Ryan
Committed r6219 On Fri, Sep 25, 2009 at 1:48 PM, Ray Ryan wrote: > Since the logic hasn't changed, I'll take your LGTM and run with it. > FYI, this is an object we plug in to the XML parser. It gets to turn URLs > into streams. When it sees us serving from the magic url where our xhtml.ent > fil

[gwt-contrib] Re: Changes served location of UiBinder's xhtml.ent from svn to downloads

2009-09-25 Thread Ray Ryan
Since the logic hasn't changed, I'll take your LGTM and run with it. FYI, this is an object we plug in to the XML parser. It gets to turn URLs into streams. When it sees us serving from the magic url where our xhtml.ent file lives, it returns a local copy. Otherwise each time someone compiled a ui.

[gwt-contrib] Re: Changes served location of UiBinder's xhtml.ent from svn to downloads

2009-09-25 Thread jlabanca
LGTM Code looks fine, but I really don't know what these files are doing, so I can't review the logic. http://gwt-code-reviews.appspot.com/72801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~-

[gwt-contrib] Re: Changes served location of UiBinder's xhtml.ent from svn to downloads

2009-09-25 Thread rjrjr
Can you look again? One of my unit tests was passing vacuously, and I also wasn't being strict enough when matching short circuited resource paths (needed to look for trailing '/' too). http://gwt-code-reviews.appspot.com/72801 --~--~-~--~~~---~--~~ http://groups.

[gwt-contrib] Re: Changes served location of UiBinder's xhtml.ent from svn to downloads

2009-09-25 Thread jgw
On 2009/09/25 18:08:31, Ray Ryan wrote: > Joel, this is to change the served location of xhtml.ent > after discussion with Andrew LGTM. http://gwt-code-reviews.appspot.com/72801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors