[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Eric Ayers
Hi Uwe, I can't get the entire patch to apply because I'm missing a file named AbstractDataTable.java from http://gwt-google-apis.googlecode.com/svn/branches/uwe/visualization Did I miss an earlier commit? On Tue, Oct 14, 2008 at 10:51 AM, Uwe Maurer [EMAIL PROTECTED] wrote: Hi, I added a

[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Eric Ayers
General: I see this coming out a lot in the hosted mode shell window - do you think it is from our visualization wrappers? [WARN] Malformed JSNI reference 'length'; expect subsequent failures java.lang.NoSuchFieldError: length ... at

[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Uwe Maurer
On Mon, Oct 20, 2008 at 8:15 PM, Eric Ayers [EMAIL PROTECTED] wrote: One other cleanup: When running under the command line, I found an error: [gwt.javac]

[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Uwe Maurer
Hi Eric, thanks for the review! The new patch is attached. On Mon, Oct 20, 2008 at 3:24 PM, Eric Ayers [EMAIL PROTECTED] wrote: General: I see this coming out a lot in the hosted mode shell window - do you think it is from our visualization wrappers? [WARN] Malformed JSNI reference

[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Eric Ayers
LGTM except for resizing code below. If you don't want the resizing behavior after all, just expunge it. On Mon, Oct 20, 2008 at 3:11 PM, Uwe Maurer [EMAIL PROTECTED] wrote: Hi Eric, thanks for the review! The new patch is attached. On Mon, Oct 20, 2008 at 3:24 PM, Eric Ayers [EMAIL