[gwt-contrib] Re: Code Review: gwt-google-apis gears Add support for message types other than String()

2008-10-15 Thread Eric Ayers
On Tue, Oct 14, 2008 at 5:43 PM, Alex Rudnick [EMAIL PROTECTED] wrote: Hey Eric :) I'll take this one. LGTM, save the (formatting) comments below and a question about documentation. gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java: 388: Should probably take out the

[gwt-contrib] Re: Code Review: gwt-google-apis gears Add support for message types other than String()

2008-10-14 Thread Alex Rudnick
Hey Eric :) I'll take this one. LGTM, save the (formatting) comments below and a question about documentation. gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java: 388: Should probably take out the commented-out testReceiveMessageObject. Unless you wanted to put this one in?

[gwt-contrib] Re: Code Review: gwt-google-apis gears Add support for message types other than String()

2008-10-14 Thread Eric Ayers
Thanks for the comments. On Tue, Oct 14, 2008 at 5:43 PM, Alex Rudnick [EMAIL PROTECTED] wrote: Hey Eric :) I'll take this one. LGTM, save the (formatting) comments below and a question about documentation. gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java: 388: Should