[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-10 Thread fredsa
Committed in r8509 http://code.google.com/p/google-web-toolkit/source/detail?r=8509 http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-10 Thread Kelly Norton
Did I already mention how awesome it is that you fixed this? awesome! /kelly On Tue, Aug 10, 2010 at 5:05 PM, fre...@google.com wrote: Committed in r8509 http://code.google.com/p/google-web-toolkit/source/detail?r=8509 http://gwt-code-reviews.appspot.com/730802/show -- If you

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread fredsa
http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread scottb
LGTM, except I kind of preferred the red. :) http://gwt-code-reviews.appspot.com/730802/diff/11001/12003 File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right): http://gwt-code-reviews.appspot.com/730802/diff/11001/12003#newcode387

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread fredsa
http://gwt-code-reviews.appspot.com/730802/diff/11001/12003 File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right): http://gwt-code-reviews.appspot.com/730802/diff/11001/12003#newcode387 dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java:387: onModuleLoad() threw an unexpected

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread Fred Sauer
On Wed, Aug 4, 2010 at 2:42 PM, sco...@google.com wrote: LGTM, except I kind of preferred the red. :) Patches welcome :-) http://gwt-code-reviews.appspot.com/730802/diff/11001/12003 File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right):

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread fredsa
http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-04 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-02 Thread scottb
LGTM, but we should prefix the method with __gwt_ for namespacing. http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

2010-08-02 Thread fredsa
http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors