[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

2011-05-14 Thread zundel
http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

2011-05-14 Thread Scott Blum
On Sat, May 14, 2011 at 9:22 AM, zun...@google.com wrote: I know I've asked this before, but if code isn't live in the runer, we replace it with null.nullMethod(), null.nullField or the likes. Why do we keep this around? Dead Code elimination usually gets rid of it (but not always?) is it

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

2011-05-13 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

2011-05-13 Thread scottb
http://gwt-code-reviews.appspot.com/1442802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

[gwt-contrib] Re: Decentralize nullmethod/nullfield (issue1442802)

2011-05-13 Thread jbrosenberg
LGTM http://gwt-code-reviews.appspot.com/1442802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors