[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

2011-06-21 Thread zundel
LGTM, just some comments. http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java (right):

[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

2011-06-21 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1467801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

2011-06-21 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java (right):