LGTM
http://gwt-code-reviews.appspot.com/1634803/diff/1/plugins/xpcom/ExternalWrapper.cpp File plugins/xpcom/ExternalWrapper.cpp (right): http://gwt-code-reviews.appspot.com/1634803/diff/1/plugins/xpcom/ExternalWrapper.cpp#newcode267 plugins/xpcom/ExternalWrapper.cpp:267: bool remember = false; if this change doesn't actually affect our usage, then we could create our own typedef to switch between the two. e.g. (in a header that affected files include--looks like only ExternalWrapper is affected though) #if GECKO_VERSION < 10000 typedef PRBool MozBool #else typedef bool MozBool #endif //GECKO_VERSION and then in the actual usage, just use MozBool instead. http://gwt-code-reviews.appspot.com/1634803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
