Seems fine. (I'll take care of these nits.)
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapte
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapte
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/Edi
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/Edi
I'm not all that familiar with the editor framework but perhaps there's
a cleaner way to do this? (See comments.)
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.j
On 2013/01/13 19:28:16, tbroyer wrote:
Ping; would be great to have it in 2.5.1! (IIRC, we initially talked
about
including it in 2.5.0 and finally decided to postpone it to the next
release)
This looks like a breaking change but it is hard for me to guess how
likely it is going to break thin
Ping; would be great to have it in 2.5.1! (IIRC, we initially talked
about including it in 2.5.0 and finally decided to postpone it to the
next release)
http://gwt-code-reviews.appspot.com/1587803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ping
http://gwt-code-reviews.appspot.com/1587803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors