LGTM - assuming you remove the marker deletions
FYI - Our Eclipse projects dump class files out to war/WEB-INF/classes,
but the classes file go in trunk/eclipse/samples/ whereas the source is
in trunk/samples/. Without the marker file, Eclipse wouldn't copy the
classes/ folder to
I'll review this by Monday. Feel free to send me mean Shakespearean insults
over chat if I don't get to it by Monday evening.
Thanks,
John LaBanca
jlaba...@google.com
On Thu, Mar 18, 2010 at 3:17 PM, rj...@google.com wrote:
Perhaps eclipse deleted them. I forget why they exist exactly,
On 2010/03/18 17:54:20, unnurg wrote:
Hmm - not sure why those marker classes showed up in the CL - looking
into what I did wrong there...
http://gwt-code-reviews.appspot.com/239801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Perhaps eclipse deleted them. I forget why they exist exactly, something
to do with eclipse and our canned configs for the demos.
@jlabanca, can you take the review? You know that world better than I
do.
On 2010/03/18 17:56:50, unnurg wrote:
On 2010/03/18 17:54:20, unnurg wrote:
Hmm - not
