[gwt-contrib] Re: FormPanel iframe name collisions

2009-12-14 Thread John LaBanca
Isn't it technically possible for multiple apps to have the same module name? For example, I can image an app where the user customizes the interface, and includes the same app twice. Thanks, John LaBanca jlaba...@google.com On Mon, Dec 14, 2009 at 5:49 PM, knor...@google.com wrote:

Re: [gwt-contrib] Re: FormPanel iframe name collisions

2009-12-14 Thread John Tamplin
On Mon, Dec 14, 2009 at 5:50 PM, John LaBanca jlaba...@google.com wrote: Isn't it technically possible for multiple apps to have the same module name? For example, I can image an app where the user customizes the interface, and includes the same app twice. Yes, absolutely. -- John A.

[gwt-contrib] Re: FormPanel iframe name collisions

2009-12-14 Thread Kelly Norton
No, if two modules with the same name load, it's only through luck: Here's one example of why: http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js#90 /kel On Mon, Dec 14, 2009 at 5:50 PM, John LaBanca jlaba...@google.com

[gwt-contrib] Re: FormPanel iframe name collisions

2009-12-14 Thread knorton
http://gwt-code-reviews.appspot.com/125801/diff/1/4 File user/src/com/google/gwt/user/client/ui/FormPanel.java (right): http://gwt-code-reviews.appspot.com/125801/diff/1/4#newcode298 Line 298: /** Rather than polluting $wnd even more, why not make the id: FormPanel_ + GWT.getModuleName() +