LGTM
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode231
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010
File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66
user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66:
*
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010
File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66
user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66:
*
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM now. I'll let you and Bob sort out the rest.
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40020
File
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40020#newcode43
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:43:
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
just some nits and a possible TODO
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003#newcode2
Almost there
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28
dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28:
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40003#newcode2
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:2:
*
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28
dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28:
void
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28
dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28:
void
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28
dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28:
void
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004#newcode30
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:30:
public
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004#newcode30
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:30:
public
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009
File dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009#newcode574
dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java:574: *
structure of a
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009
File dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6009#newcode574
dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java:574: *
structure of a
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The mix of explicit vs. implicit dependency tracking is confusing. You
have an explicit requirements.addConfigurationProperty(), but the
@Source-file tracking is implicit via
ResourceContext.getResourcesForMethod().
The SupportsGeneratorResourceCaching interface makes sense, but the
On 2010/12/21 16:02:35, bobv wrote:
Bob, thanks for the comments...
The mix of explicit vs. implicit dependency tracking is confusing.
You have an
explicit requirements.addConfigurationProperty(), but the @Source-file
tracking
is implicit via ResourceContext.getResourcesForMethod().
(grumbleThe reply function doesn't publish comments/grumble)
http://gwt-code-reviews.appspot.com/1236801/diff/1/3
File user/src/com/google/gwt/resources/ext/ResourceContext.java (right):
http://gwt-code-reviews.appspot.com/1236801/diff/1/3#newcode147
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/diff/1/3
File user/src/com/google/gwt/resources/ext/ResourceContext.java (right):
http://gwt-code-reviews.appspot.com/1236801/diff/1/3#newcode147
user/src/com/google/gwt/resources/ext/ResourceContext.java:147: * a
given method. This data will be
36 matches
Mail list logo
